E8-T3: Address code review feedback - fix port notes, subshell usage, and doc paths

Co-authored-by: dylan-mccarthy <[email protected]>

Author: Copilot

DEMO.md

@@ -23,6 +23,10 @@ Before running the demo, ensure you have:
 - **curl** (command-line HTTP client)
 - **4GB+ RAM** available for containers
 
+> **Note**: This demo uses Docker Compose and accesses the Control Plane API on port 8080.  
+> If running services locally with `dotnet run`, the API uses port 5109 by default.  
+> Set `CONTROL_PLANE_URL` environment variable to override the default URL.
+
 ### Installation
 
 Install prerequisites on different platforms:
@@ -364,7 +368,7 @@ environment:
 docker compose restart control-plane node-runtime
 ```
 
-See [Azure AI Foundry Integration](../docs/AZURE_AI_FOUNDRY_INTEGRATION.md) for detailed setup.
+See [Azure AI Foundry Integration](docs/AZURE_AI_FOUNDRY_INTEGRATION.md) for detailed setup.
 
 ## Testing
 
@@ -528,7 +532,7 @@ After completing the demo:
    ```
 
 3. **Configure Azure AI Foundry**
-   - See [Azure AI Foundry Integration](../docs/AZURE_AI_FOUNDRY_INTEGRATION.md)
+   - See [Azure AI Foundry Integration](docs/AZURE_AI_FOUNDRY_INTEGRATION.md)
 
 4. **Run Performance Tests**
    ```bash
@@ -551,7 +555,7 @@ After completing the demo:
 - [System Architecture Document](../sad.md) - High-level design
 - [Invoice Classifier Agent](../docs/INVOICE_CLASSIFIER.md) - Agent details
 - [Agent Definitions](../agents/README.md) - Agent configuration
-- [Azure AI Foundry](../docs/AZURE_AI_FOUNDRY_INTEGRATION.md) - LLM setup
+- [Azure AI Foundry](docs/AZURE_AI_FOUNDRY_INTEGRATION.md) - LLM setup
 - [Deployment Guide](../DEPLOYMENT.md) - Production deployment
 - [Observability](../OBSERVABILITY.md) - Monitoring setup
 - [CI/CD](../CI-CD.md) - Pipeline configuration

demo-invoice-classifier-noninteractive.sh

@@ -23,7 +23,7 @@ RED='\033[0;31m'
 NC='\033[0m'
 
 # Configuration
-CONTROL_PLANE_URL="${CONTROL_PLANE_URL:-http://localhost:8080}"
+CONTROL_PLANE_URL="${CONTROL_PLANE_URL:-http://localhost:8080}"  # Docker Compose port (local dev uses 5109)
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 TIMEOUT=120
 
@@ -95,9 +95,10 @@ sleep 5
 # Seed agent
 log_info "Seeding Invoice Classifier agent..."
 if [ -f "${SCRIPT_DIR}/agents/seed-invoice-classifier.sh" ]; then
-    cd "${SCRIPT_DIR}/agents"
-    CONTROL_PLANE_URL="${CONTROL_PLANE_URL}" ./seed-invoice-classifier.sh > /dev/null 2>&1
-    cd "${SCRIPT_DIR}"
+    (
+        cd "${SCRIPT_DIR}/agents" && \
+        CONTROL_PLANE_URL="${CONTROL_PLANE_URL}" ./seed-invoice-classifier.sh > /dev/null 2>&1
+    )
     log_success "Agent seeded"
 else
     log_error "Seed script not found"

demo-invoice-classifier.sh

@@ -34,7 +34,7 @@ BOLD='\033[1m'
 NC='\033[0m' # No Color
 
 # Configuration
-CONTROL_PLANE_URL="${CONTROL_PLANE_URL:-http://localhost:8080}"
+CONTROL_PLANE_URL="${CONTROL_PLANE_URL:-http://localhost:8080}"  # Docker Compose port (local dev uses 5109)
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Helper functions
@@ -157,9 +157,10 @@ seed_agent() {
     fi
 
     log_step "Running agent seed script..."
-    cd "${SCRIPT_DIR}/agents"
-    CONTROL_PLANE_URL="${CONTROL_PLANE_URL}" ./seed-invoice-classifier.sh
-    cd "${SCRIPT_DIR}"
+    (
+        cd "${SCRIPT_DIR}/agents" && \
+        CONTROL_PLANE_URL="${CONTROL_PLANE_URL}" ./seed-invoice-classifier.sh
+    )
 
     log_success "Invoice Classifier agent deployed successfully"
 }