error updating to 0.10.0

[YuriFontella]

hello,

I was using it this way to update at a time interval and everything worked perfectly

async def job():
    scheduler.add_task(fn=start, trigger='interval', minutes=30)
    scheduler.start()

After updating to version 0.10.0 this error started to appear

Traceback (most recent call last):
  File "D:\dev\up\jobs\conversions\server\scripts.py", line 189, in job
    scheduler.add_task(fn=start, trigger='interval', minutes=30)
  File "C:\Users\yurif\AppData\Local\pypoetry\Cache\virtualenvs\conversions-PWHo6r0i-py3.12\Lib\site-packages\asyncz\schedulers\base.py", line 503, in add_task
    task = Task(**task_kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\yurif\AppData\Local\pypoetry\Cache\virtualenvs\conversions-PWHo6r0i-py3.12\Lib\site-packages\asyncz\tasks\base.py", line 72, in __init__
    self.update_task(fn=fn, **kwargs)
  File "C:\Users\yurif\AppData\Local\pypoetry\Cache\virtualenvs\conversions-PWHo6r0i-py3.12\Lib\site-packages\asyncz\tasks\base.py", line 124, in update_task
    updates["name"] = get_callable_name(fn)
                      ^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\yurif\AppData\Local\pypoetry\Cache\virtualenvs\conversions-PWHo6r0i-py3.12\Lib\site-packages\asyncz\utils.py", line 243, in get_callable_name
    raise TypeError(f"Unable to determine a name for {func!r} -- maybe it is not a callable?")
TypeError: Unable to determine a name for None -- maybe it is not a callable?

I didn't understand if it was to define a name

scheduler.add_task(fn=start, trigger='interval', minutes=30, name='job_conversions')

2024-07-27 13:27:10.824 | INFO     | asyncz.schedulers.base:start:204 - Scheduler started.
INFO:     Application startup complete.
2024-07-27 13:27:10.825 | DEBUG    | asyncz.schedulers.base:process_tasks:969 - Looking for tasks to run.
2024-07-27 13:27:10.825 | DEBUG    | asyncz.schedulers.base:process_tasks:1048 - No tasks. Waiting until task is added.

defining a name did not present the error
but it did not execute the task... I looked in the documentation to see if I had changed any way of using it and nothing

I ended up downgrading to 0.9.0
thanks

[tarsil]

@YuriFontella keep it in the version 0.9.0 until we run further analysis on this error. We started refactoring some internals of asyncz and we might have introduced a bug. Apologies.

@devkral can we investigate this please?

[tarsil]

@YuriFontella could you please provide us your start? How did you declare it? The function itself

[tarsil]

Thank you @YuriFontella this will help to narrow the problem down. Keep the 0.9.0 untila further update comes through. It should work as per normal

[YuriFontella]

ok
no problem

[devkral]

Sry for the late answer: I see what you are trying to do but this is not how the setup is intended. Try this instead:

from litestar import Litestar, get
from asyncz.schedulers import AsyncIOScheduler

scheduler = AsyncIOScheduler()


@get('/')
async def on_get() -> bool:
    return True


async def job():  # you want a bg job right?
    print('bg job')


scheduler.add_task(fn=job, trigger='interval', minutes=30)

app = Litestar(
    route_handlers=[on_get],
    on_startup=[scheduler.start], on_shutdown=[scheduler.shutdown]
)

[devkral]

sry, you are right there is a bug: the name cannot be retrieved but you can easily workaround like this:

from litestar import Litestar, get
from asyncz.schedulers import AsyncIOScheduler

scheduler = AsyncIOScheduler()


@get('/')
async def on_get() -> bool:
    return True


async def job():  # you want a bg job right?
    print('bg job')


scheduler.add_task(fn=job, trigger='interval', minutes=30, name="job")  # add manually a name and it should work

app = Litestar(
    route_handlers=[on_get],
    on_startup=[scheduler.start], on_shutdown=[scheduler.shutdown]
)

[devkral]

I was blind: it is the named parameter fn. Fn is now fn_or_task. Just pass it positional

[devkral]

Bug is the name cannot be autoretrieved (but should) I think it is because of future annotations.

[tarsil]

I do think so too. That is why I asked for the example. When we pass future annotations it transforms everything into a string and messes up a bit. Although we will fix this and add extra testing on top of it

[devkral]

The bug is the fn name: it is fn_or_task. Just pass it positional. This is why no fn could be retrieved.

[tarsil]

Let's make backwards compatible and basically allow also the fn then

[devkral]

Next release should fix the issue, but you can use fn_or_task instead to prevent a DeprecationWarning.

[tarsil]

Yes. Realese should come out soon with that. Thank you @devkral

[devkral]

release is out.

[tarsil]

Give it a try @YuriFontella with the latest version 🙂. Great job @devkral

[YuriFontella]

updated to version 0.10.1 and everything worked
nice work

thanks @tarsil @devkral