Merge pull request #207 from dynamicslab/fix-set-params

akaptano · web-flow · commit a7f94bfb9171 · 2022-06-21T11:34:50.000-04:00
BUG: SINDyDerivative set_params() missed sklearn interface
diff --git a/pysindy/differentiation/sindy_derivative.py b/pysindy/differentiation/sindy_derivative.py
@@ -52,7 +52,7 @@ def set_params(self, **params):
             # Simple optimization to gain speed (inspect is slow)
             return self
         else:
-            self.kwargs.update(params)
+            self.kwargs.update(params["kwargs"])
 
         return self
 
diff --git a/test/differentiation/test_differentiation_methods.py b/test/differentiation/test_differentiation_methods.py
@@ -262,6 +262,13 @@ def test_wrapper_equivalence_with_dxdt(data, derivative_kws):
         )
 
 
+def test_sindy_derivative_kwarg_update():
+    method = SINDyDerivative(kind="spectral", foo=2)
+    method.set_params(kwargs={"kind": "spline", "foo": 1})
+    assert method.kwargs["kind"] == "spline"
+    assert method.kwargs["foo"] == 1
+
+
 @pytest.mark.parametrize(
     "data, derivative_kws",
     [

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,13 @@ def test_wrapper_equivalence_with_dxdt(data, derivative_kws):`
`262`	`262`	`)`
`263`	`263`
`264`	`264`
	`265`	`+def test_sindy_derivative_kwarg_update():`
	`266`	`+ method = SINDyDerivative(kind="spectral", foo=2)`
	`267`	`+ method.set_params(kwargs={"kind": "spline", "foo": 1})`
	`268`	`+ assert method.kwargs["kind"] == "spline"`
	`269`	`+ assert method.kwargs["foo"] == 1`
	`270`	`+`
	`271`	`+`
`265`	`272`	`@pytest.mark.parametrize(`
`266`	`273`	`"data, derivative_kws",`
`267`	`274`	`[`