🔧 feat(status_transitions): Improve status order handling with API response

Enhance status transition logic to dynamically build status order from
Phabricator's maniphest.querystatuses API. Add fallback to hardcoded
order when API response is unavailable. Modify functions to accept
optional API response for more flexible status progression tracking.

Author: Timpan4

phabfive/status_transitions.py

@@ -8,11 +8,11 @@
 
 log = logging.getLogger(__name__)
 
-# Status ordering for comparison and workflow progression
+# Fallback status ordering for comparison and workflow progression
 # Lower number = earlier in the workflow
 # Used to determine if status was "raised" (progressed forward) or "lowered" (moved backward)
-# Statuses like "Wontfix", "Invalid", "Duplicate" are considered terminal/closed states
-STATUS_ORDER = {
+# This is only used if the API call to maniphest.querystatuses fails
+FALLBACK_STATUS_ORDER = {
     "open": 0,
     "blocked": 1,
     "wontfix": 2,
@@ -22,14 +22,64 @@
 }
 
 
-def get_status_order(status_name):
+def _build_status_order_from_api(api_response):
+    """
+    Build status order mapping from API response.
+
+    The maniphest.querystatuses API returns:
+    - openStatuses: list of open status keys
+    - closedStatuses: dict of closed status values
+    - statusMap: dict mapping status keys to display names
+
+    Parameters
+    ----------
+    api_response : dict
+        Response from maniphest.querystatuses API
+
+    Returns
+    -------
+    dict
+        Mapping of status name (lowercase) to order number
+    """
+    if not api_response:
+        return FALLBACK_STATUS_ORDER
+
+    order_map = {}
+
+    # Extract status information from API response
+    open_status_keys = api_response.get("openStatuses", [])
+    closed_status_values = api_response.get("closedStatuses", {})
+    status_map = api_response.get("statusMap", {})
+
+    # Build order: open statuses first (lower numbers), then closed statuses
+    current_order = 0
+
+    # Add open statuses
+    for status_key in open_status_keys:
+        status_name = status_map.get(status_key, status_key)
+        order_map[status_name.lower()] = current_order
+        current_order += 1
+
+    # Add closed statuses
+    for status_key in closed_status_values.values():
+        status_name = status_map.get(status_key, status_key)
+        order_map[status_name.lower()] = current_order
+        current_order += 1
+
+    return order_map
+
+
+def get_status_order(status_name, api_response=None):
     """
     Get the numeric order of a status for comparison.
 
     Parameters
     ----------
     status_name : str
         Status name (case-insensitive)
+    api_response : dict, optional
+        Full response from maniphest.querystatuses API.
+        If not provided, uses fallback ordering.
 
     Returns
     -------
@@ -38,7 +88,14 @@ def get_status_order(status_name):
     """
     if not status_name:
         return None
-    return STATUS_ORDER.get(status_name.lower())
+
+    # Build order map from API response if provided
+    if api_response:
+        order_map = _build_status_order_from_api(api_response)
+    else:
+        order_map = FALLBACK_STATUS_ORDER
+
+    return order_map.get(status_name.lower())
 
 
 class StatusPattern:
@@ -49,15 +106,18 @@ class StatusPattern:
     Multiple patterns can be combined with OR logic.
     """
 
-    def __init__(self, conditions):
+    def __init__(self, conditions, api_response=None):
         """
         Parameters
         ----------
         conditions : list
             List of condition dicts, each with keys like:
             {"type": "from", "status": "Open", "direction": "raised"}
+        api_response : dict, optional
+            Full response from maniphest.querystatuses API for ordering
         """
         self.conditions = conditions
+        self.api_response = api_response
 
     def matches(self, status_transactions, current_status):
         """
@@ -131,8 +191,8 @@ def _matches_from(self, condition, status_transactions):
                     return True
 
                 # Check direction
-                old_order = get_status_order(old_value)
-                new_order = get_status_order(new_value)
+                old_order = get_status_order(old_value, self.api_response)
+                new_order = get_status_order(new_value, self.api_response)
 
                 if old_order is not None and new_order is not None:
                     if direction == "raised" and new_order > old_order:
@@ -203,8 +263,8 @@ def _matches_raised(self, status_transactions):
             if old_value is None or new_value is None:
                 continue
 
-            old_order = get_status_order(old_value)
-            new_order = get_status_order(new_value)
+            old_order = get_status_order(old_value, self.api_response)
+            new_order = get_status_order(new_value, self.api_response)
 
             if old_order is not None and new_order is not None:
                 if new_order > old_order:  # Higher number = further along
@@ -221,8 +281,8 @@ def _matches_lowered(self, status_transactions):
             if old_value is None or new_value is None:
                 continue
 
-            old_order = get_status_order(old_value)
-            new_order = get_status_order(new_value)
+            old_order = get_status_order(old_value, self.api_response)
+            new_order = get_status_order(new_value, self.api_response)
 
             if old_order is not None and new_order is not None:
                 if new_order < old_order:  # Lower number = earlier stage
@@ -314,7 +374,7 @@ def _parse_single_condition(condition_str):
     return result
 
 
-def parse_status_patterns(patterns_str):
+def parse_status_patterns(patterns_str, api_response=None):
     """
     Parse status pattern string into list of StatusPattern objects.
 
@@ -326,6 +386,8 @@ def parse_status_patterns(patterns_str):
     ----------
     patterns_str : str
         Pattern string like "from:Open:raised+in:Resolved,to:Closed"
+    api_response : dict, optional
+        Full response from maniphest.querystatuses API for ordering
 
     Returns
     -------
@@ -372,7 +434,7 @@ def parse_status_patterns(patterns_str):
             conditions.append(condition)
 
         if conditions:
-            patterns.append(StatusPattern(conditions))
+            patterns.append(StatusPattern(conditions, api_response))
 
     if not patterns:
         raise PhabfiveException("No valid status patterns found")