-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Environment
- Python version: 3.10.x
- Phabfive version: latest master version
Steps to Reproduce
When developing code, i stumbled upon this that when i export a development phabricator url including a port number, it fails a validation step that it should not fail on. We assume that in our regex checks that we have specified a valid URL instead of just trying the URL no matter what it is and letting it fail.
export PHAB_URL=http://phabricator.domain.tld:81/api/
Result: PHAB_URL is malformed, example: http://127.0.0.1/api/
Possible solution to this problem is to either remove the regex check, implement port checking in the regex, change from regex validation to be a requests/curl validation instead
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working