list project opportunities test and some other updates

Author: dy-waltergrantward

dynata_rex/opportunity_registry.py

@@ -119,8 +119,9 @@ def ack_opportunities(self, opportunities: List[int]) -> None:
         res = self.make_request.post(endpoint, opportunities)
         return res
 
-    def download_collection(self, collection_id: int) -> list:
+    def download_collection(self, collection_id: str) -> list:
         """Download targeting from a collection cell"""
         endpoint = f"{self.base_url}/download-collection"
-        data = {"id": collection_id}
-        return self.make_request.post(endpoint, data)
+        data = {"id": str(collection_id)}
+        res = self.make_request.post(endpoint, data)
+        return str(res).split('\n')

tests/data/test_download_collection.txt

@@ -0,0 +1,131 @@
+10110
+10120
+10150
+10350
+10430
+10640
+11520
+11530
+11610
+11640
+11730
+11840
+12310
+12430
+12530
+12560
+12710
+12730
+12750
+12850
+12870
+12930
+12950
+13330
+13430
+13470
+13560
+13640
+13770
+13850
+14240
+14250
+14350
+14430
+15122
+15144
+15148
+15220
+15227
+15310
+15314
+15325
+15345
+15412
+15418
+15710
+15810
+16122
+16128
+16340
+16411
+16423
+16435
+16451
+16454
+16514
+16720
+16968
+17114
+17132
+17134
+17143
+17148
+17413
+17415
+17423
+17435
+17510
+20123
+20133
+20212
+20236
+30114
+30164
+35116
+35132
+40117
+40131
+40135
+40173
+40233
+40255
+40263
+40265
+40286
+41361
+42118
+43111
+45123
+46121
+46125
+50242
+50246
+50249
+50263
+52411
+55221
+55224
+55271
+55284
+57151
+57552
+60225
+60227
+60238
+60265
+60271
+60285
+60293
+61121
+61122
+61253
+61254
+61256
+64129
+65112
+65144
+76113
+80114
+80118
+80119
+80221
+80228
+80231
+80361
+83122
+90113
+90222
+90223
+95111
+15811

tests/shared.py

@@ -32,10 +32,13 @@ def load_test_data():
     """Load data out of /data folder so we can use it in our tests"""
     out = {}
     for fn in os.listdir(f"{os.getcwd()}/data"):
-        if fn.endswith('.json'):  # ignore non-json
+        key = fn.split('.')[0]
+        if fn.endswith('.json'):
             with open(f'{os.getcwd()}/data/{fn}') as f:
-                key = fn.split('.')[0]
                 out[key] = json.load(f)
+        if fn.endswith('.txt'):
+            with open(f'{os.getcwd()}/data/{fn}') as f:
+                out[key] = f.read()
     return out
 
 

tests/test_opportunity_registry.py

@@ -132,9 +132,6 @@ def test_list_opportunities_assert_ack_for_invalid_opportunity(session_post,
 @patch.object(dynata_rex.OpportunityRegistry, "ack_opportunities")
 @patch.object(requests.Session, "post")
 def test_ack_opportunity(session_post, ack_method):
-    """list opportunities should 'ack' an opportunity returned
-       that it cannot convert into an Opportunity object"""
-
     data = TEST_DATA['test_list_opportunities'][0]
 
     session_post.return_value = ResponseMock._response_mock(
@@ -144,34 +141,55 @@ def test_ack_opportunity(session_post, ack_method):
 
     assert ack_method.call_count == 1
 
+    # Make sure we called parent `ack_opportunities` method with
+    # [ data['id'] ]
+    assert ack_method.call_args == (([data['id']],),)
+
 
-@patch.object(dynata_rex.OpportunityRegistry, "ack_opportunities")
 @patch.object(requests.Session, "post")
-def test_ack_opportunities(session_post, ack_method):
+def test_ack_opportunities(session_post):
     """list opportunities should 'ack' an opportunity returned
        that it cannot convert into an Opportunity object"""
 
-    data = TEST_DATA['test_list_opportunities']
+    data = [x['id'] for x in TEST_DATA['test_list_opportunities']]
 
     session_post.return_value = ResponseMock._response_mock(
-        200, content_type="application/json"
+        204, content_type="application/json"
     )
 
     REGISTRY.ack_opportunities(data)
 
-    assert ack_method.call_count == 1
+    assert session_post.call_count == 1
+    assert session_post.call_args[1]['data'] == json.dumps(data)
+
+
+@patch.object(requests.Session, "post")
+def test_list_project_opportunities(session_post):
+    data = [17039, 17344, 17038, 17040, 17041, 17042]
+
+    session_post.return_value = ResponseMock._response_mock(
+        200, content=json.dumps(data), content_type="application/json"
+    )
+    res = REGISTRY.list_project_opportunities(99999)
+
+    assert session_post.call_args[1]['data'] == json.dumps({
+        'project_id': 99999,
+    })
+    assert res == data
 
 
 @patch.object(requests.Session, "post")
 def test_download_collection(session_post):
     """list opportunities should 'ack' an opportunity returned
        that it cannot convert into an Opportunity object"""
 
-    data = TEST_DATA['test_list_opportunities'][0]
+    data = TEST_DATA['test_download_collection']
 
     session_post.return_value = ResponseMock._response_mock(
-        200, content=json.dumps(data), content_type="application/json"
+        200, content=data, content_type="text/csv"
     )
 
-    r = REGISTRY.download_collection(data['id'])
-    assert isinstance(r, dict)
+    r = REGISTRY.download_collection('1234567')
+
+    assert isinstance(r, list)
+