Skip to content

Commit 8854a6c

Browse files
Bump com.google.errorprone:error_prone_core from 2.42.0 to 2.43.0 (micrometer-metrics#6819)
* Bump com.google.errorprone:error_prone_core from 2.42.0 to 2.43.0 Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.42.0 to 2.43.0. - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.42.0...v2.43.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_core dependency-version: 2.43.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Only enabled Error Prone on JDK 21+ Error Prone 2.43.0 requires JDK 21+ * Only include Error Prone dependencies when enabled JDK 17 compiler crashes when the errorprone dependency is there, even if the plugin is disabled. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tommy Ludwig <[email protected]>
1 parent b5ef207 commit 8854a6c

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

build.gradle

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ subprojects {
126126
// see https://github.com/uber/NullAway/wiki/JSpecify-Support
127127
option("NullAway:JSpecifyMode", "true")
128128
}
129-
if (!javaLanguageVersion.canCompileOrRun(17)) {
130-
// Error Prone does not work with JDK <17
129+
if (!javaLanguageVersion.canCompileOrRun(21)) {
130+
// Error Prone 2.43.0 requires JDK 21+
131131
enabled = false
132132
}
133133
if (System.env.CI != null) {
@@ -172,8 +172,10 @@ subprojects {
172172
// Dependencies for all projects that are not transitive to consumers of our modules
173173
dependencies {
174174
checkstyle libs.spring.javaformatCheckstyle
175-
errorprone(libs.errorprone)
176-
errorprone(libs.nullAway)
175+
if (javaLanguageVersion.canCompileOrRun(21)) {
176+
errorprone(libs.errorprone)
177+
errorprone(libs.nullAway)
178+
}
177179
}
178180

179181
tasks {

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ dropwizardMetricsCore5 = { module = "io.dropwizard.metrics5:metrics-core", versi
101101
dynatraceUtils = { module = "com.dynatrace.metric.util:dynatrace-metric-utils-java", version.ref = "dynatrace-utils" }
102102
ehcache2 = { module = "net.sf.ehcache:ehcache", version.ref = "ehcache2" }
103103
ehcache3 = { module = "org.ehcache:ehcache", version.ref = "ehcache3" }
104-
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.42.0" }
104+
errorprone = { module = "com.google.errorprone:error_prone_core", version = "2.43.0" }
105105
felixFramework = "org.apache.felix:org.apache.felix.framework:7.0.5"
106106
felixScr = "org.apache.felix:org.apache.felix.scr:2.2.14"
107107
gmetric4j = { module = "info.ganglia.gmetric4j:gmetric4j", version.ref = "gmetric4j" }

0 commit comments

Comments
 (0)