Missing organization validation when add new Pipelines

[polaroi8d]

If a user provides an invalid Organization name, the application throws an internal server error. It would be helpful to validate the Organization name before saving.

Url: /team/pipelines#new

[dxtym]

Hello, can I give this a try?

[polaroi8d]

Hi @dxtym, feel free.

[dxtym]

@polaroi8d

I tried to recreate the issue and was wondering if I got it right. Is the error the same as the one in the image? From what I understand, it first checks if the pipeline exists and then creates.

[polaroi8d]

@dxtym the problem is that when a user wants to add a pipeline to the platform which currently only works with Azure DevOps pipelines, we don’t check whether the organization where the pipeline is located actually exists. As a result, users can accidentally create pipelines that don’t work from the start. What we should do is check whether the given organization exists when the user tries to create the pipeline. The question is whether we can check that in Azure DevOps, or what we would need in order to be able to check it.

[dxtym]

dyrectorio/web/crux/src/services/azure-devops.service.ts

Lines 79 to 88 in efdd9d6

	if (!res.ok) {
	const errorMessage = 'Failed to fetch pipelines'
	this.logger.error(errorMessage)
	throw new CruxInternalServerErrorException({
	message: errorMessage,
	property: 'repository.organization',
	value: projectName,
	})
	}

Shouldn't these lines of code already validate if organization exists or not?