Skip to content

Commit e131a22

Browse files
dzackgarzaclaude
andcommitted
fix: restore strict_max_version as "*" — required by Zotero AOM
Absent strict_max_version is treated as 0 (incompatible), not unbounded. Using "*" gives no practical upper bound while satisfying the field requirement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e567744 commit e131a22

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

fulltext-attach-plugin/bootstrap.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
var FulltextAttachEndpoint;
22
var OpenCodeWriteEndpoint;
33
var PluginVersionEndpoint;
4-
var PLUGIN_VERSION = "3.1.3";
4+
var PLUGIN_VERSION = "3.1.4";
55
var FULLTEXT_ATTACH_PATH = "/fulltext-attach";
66
var LOCAL_WRITE_PATH = "/opencode-zotero-write";
77
var VERSION_PATH = "/opencode-zotero-plugin-version";
88
var ADDON_ID = "fulltext-attach@dzackgarza.com";
99
var HOMEPAGE_URL = "https://github.com/dzackgarza/zotero-attachment-plugin";
1010
var UPDATE_URL = "https://raw.githubusercontent.com/dzackgarza/zotero-attachment-plugin/main/fulltext-attach-plugin/updates.json";
1111
var STRICT_MIN_VERSION = "7.0";
12+
var STRICT_MAX_VERSION = "*";
1213
var TESTED_ZOTERO_VERSION = "8.0.1";
1314
var PLUGIN_CAPABILITIES = [
1415
"fulltext_attach",
@@ -65,6 +66,7 @@ function pluginVersionPayload() {
6566
},
6667
compatibility: {
6768
strict_min_version: STRICT_MIN_VERSION,
69+
strict_max_version: STRICT_MAX_VERSION,
6870
tested_zotero_version: TESTED_ZOTERO_VERSION,
6971
},
7072
capabilities: PLUGIN_CAPABILITIES.slice(),

fulltext-attach-plugin/build.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
LOCAL_WRITE_PATH,
1919
REPO_URL,
2020
STRICT_MIN_VERSION,
21+
STRICT_MAX_VERSION,
2122
TESTED_ZOTERO_VERSION,
2223
UPDATE_MANIFEST_FILENAME,
2324
UPDATE_MANIFEST_URL,
@@ -41,6 +42,7 @@
4142
"HOMEPAGE_URL": re.compile(r'var HOMEPAGE_URL = .*?;'),
4243
"UPDATE_URL": re.compile(r'var UPDATE_URL = .*?;'),
4344
"STRICT_MIN_VERSION": re.compile(r'var STRICT_MIN_VERSION = .*?;'),
45+
"STRICT_MAX_VERSION": re.compile(r'var STRICT_MAX_VERSION = .*?;'),
4446
"TESTED_ZOTERO_VERSION": re.compile(r'var TESTED_ZOTERO_VERSION = .*?;'),
4547
}
4648
BOOTSTRAP_VAR_VALUES = {
@@ -52,6 +54,7 @@
5254
"HOMEPAGE_URL": REPO_URL,
5355
"UPDATE_URL": UPDATE_MANIFEST_URL,
5456
"STRICT_MIN_VERSION": STRICT_MIN_VERSION,
57+
"STRICT_MAX_VERSION": STRICT_MAX_VERSION,
5558
"TESTED_ZOTERO_VERSION": TESTED_ZOTERO_VERSION,
5659
}
5760

@@ -69,6 +72,7 @@ def build_manifest() -> dict[str, object]:
6972
"zotero": {
7073
"id": ADDON_ID,
7174
"strict_min_version": STRICT_MIN_VERSION,
75+
"strict_max_version": STRICT_MAX_VERSION,
7276
"update_url": UPDATE_MANIFEST_URL,
7377
}
7478
},
@@ -127,6 +131,7 @@ def build_updates_manifest(xpi_hash: str) -> dict[str, object]:
127131
"applications": {
128132
"zotero": {
129133
"strict_min_version": STRICT_MIN_VERSION,
134+
"strict_max_version": STRICT_MAX_VERSION,
130135
}
131136
},
132137
}
@@ -138,7 +143,7 @@ def build_updates_manifest(xpi_hash: str) -> dict[str, object]:
138143

139144
def build() -> Path:
140145
print(f"Building {ADDON_NAME} v{VERSION}")
141-
print(f"Minimum Zotero version: {STRICT_MIN_VERSION}+")
146+
print(f"Zotero compatibility: {STRICT_MIN_VERSION} - {STRICT_MAX_VERSION}")
142147
print(f"Tested target for release gating: Zotero {TESTED_ZOTERO_VERSION}")
143148

144149
update_bootstrap_metadata()

0 commit comments

Comments
 (0)