Skip to content

Log warning instead of silently swallowing exceptions in cleanup path #8

@dzackgarza

Description

@dzackgarza

Gemini reviewer flagged in PR #7 (examples/live_smoke.py:124): the cleanup function uses bare except Exception: pass which silently discards all errors. A logged warning (e.g. logging.warning or print to stderr) would preserve the intent of not masking the primary result while making cleanup failures visible for debugging.

Suggested by: gemini-code-assist[bot] on PR #7
Thread: PRRT_kwDORiY8Nc50eVlO

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions