Skip to content

Commit 5ef9326

Browse files
committed
remove unnecessary dir attributes from contribution and project cards
1 parent 3468a45 commit 5ef9326

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

web/src/components/contribution-card.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export function ContributionCard({
2020
return (
2121
<Link
2222
className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm"
23-
dir="ltr"
2423
href={getContributionURL(contribution)}
2524
// TODO-OB: there's a bug here: when passing onClick to Link, the link no longer work as a SPA link, and instead causes a full reload of the page
2625
onClick={onClick}

web/src/components/project-card.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export function ProjectCard({
1515
return (
1616
<Link
1717
href={getProjectURL(project)}
18-
dir="ltr"
1918
className="bg-base-300 w-full max-w-xs sm:max-w-sm flex flex-col rounded-lg border-base-200 border-2 overflow-hidden"
2019
// TODO-OB: there's a bug here: when passing onClick to Link, the link no longer work as a SPA link, and instead causes a full reload of the page
2120
onClick={onClick}

web/src/pages/contribute/contribution/index.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,7 @@ export default function Page(): JSX.Element {
6868
) : (
6969
<div className="flex flex-col gap-4 items-center p-4">
7070
{/* TODO-ZM: more tailored design for /contribute/:slug page instead of copy-pasting components from /contribute */}
71-
<div
72-
dir="ltr"
73-
className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm"
74-
>
71+
<div className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm">
7572
<div className="card-body markdown">
7673
<div className="card-body">
7774
<h2 className="card-title">

0 commit comments

Comments
 (0)