return 404 in api when not project found

Author: ZibanPirate

api/src/app/index.ts

@@ -18,7 +18,6 @@ import { ProjectController } from "src/project/controller";
 import { SQLiteService } from "src/sqlite/service";
 import Container from "typedi";
 
-import { ErrorMiddleware } from "./middlewares/error";
 import { LoggerMiddleware } from "./middlewares/logger";
 import { RobotsController } from "./middlewares/robots";
 import { SecurityMiddleware } from "./middlewares/security";
@@ -45,8 +44,7 @@ const routingControllersOptions: RoutingControllersOptions = {
     ContributorController,
     RobotsController,
   ],
-  middlewares: [SecurityMiddleware, ErrorMiddleware, LoggerMiddleware],
-  defaultErrorHandler: false,
+  middlewares: [SecurityMiddleware, LoggerMiddleware],
   cors: Container.get(SecurityMiddleware).cors(),
 };
 const app: Application = createExpressServer(routingControllersOptions);

api/src/app/middlewares/error.ts

@@ -1,4 +1,4 @@
-import { Controller, Get, Param } from "routing-controllers";
+import { Controller, Get, NotFoundError, Param } from "routing-controllers";
 import { Service } from "typedi";
 
 import { ProjectRepository } from "./repository";
@@ -49,6 +49,8 @@ export class ProjectController {
   public async getProjectName(@Param("id") id: number): Promise<GetProjectNameResponse> {
     const project = await this.projectRepository.findName(id);
 
+    if (!project) throw new NotFoundError("Project not found");
+
     return { project };
   }
 }

api/src/project/controller.ts

@@ -13,7 +13,6 @@ export class ProjectRepository {
   constructor(private readonly sqliteService: SQLiteService) {}
 
   public async findName(projectId: number) {
-    // @TODO-ZM: handle 404
     const statement = sql`
     SELECT
         name
@@ -23,6 +22,8 @@ export class ProjectRepository {
         id = ${projectId}
     `;
     const raw = this.sqliteService.db.get(statement);
+    if (!raw) return null;
+
     const unStringifiedRaw = unStringifyDeep(raw);
     const camelCased = camelCaseObject(unStringifiedRaw);
     return camelCased;