Skip to content

Commit fa46f3d

Browse files
authored
Small fixes (Joystream#124)
* fix: always add marshal.ts to generated code * fix: typo in db:create-migration script * fix: relax indexer version check
1 parent d70bf44 commit fa46f3d

File tree

8 files changed

+19
-13
lines changed

8 files changed

+19
-13
lines changed

.github/workflows/debug.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: debug
2+
on: [workflow_dispatch]
3+
4+
jobs:
5+
debug:
6+
name: Debug actions environment
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v1
10+
- name: Setup tmate session
11+
uses: mxschmitt/action-tmate@v3

.github/workflows/hydra-e2e-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,5 @@ jobs:
88
runs-on: ubuntu-latest
99
steps:
1010
- uses: actions/checkout@v1
11-
#- uses: satackey/action-docker-layer-caching@v0.0.11
12-
# Ignore the failure of a step and avoid terminating the job.
13-
# continue-on-error: true
1411
- name: run e2e tests
1512
run: ./scripts/e2e-test.sh

packages/hydra-cli/src/codegen.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export function codegen(options: CodegenOptions): void {
3737
function generateOrmModels(model: Model, dir: OutDir): void {
3838
const variants = collectVariants(model)
3939
const index = dir.file('model.ts')
40-
let usesMarshaling = false
4140

4241
for (const name in model) {
4342
const item = model[name]
@@ -47,7 +46,6 @@ function generateOrmModels(model: Model, dir: OutDir): void {
4746
break
4847
case 'object':
4948
generateObject(name, item)
50-
usesMarshaling = true
5149
break
5250
case 'union':
5351
generateUnion(name, item)
@@ -59,9 +57,7 @@ function generateOrmModels(model: Model, dir: OutDir): void {
5957
}
6058

6159
index.write()
62-
if (usesMarshaling) {
63-
dir.addResource('codegen/marshal.ts', 'marshal.ts')
64-
}
60+
dir.addResource('codegen/marshal.ts', 'marshal.ts')
6561

6662
function generateEntity(name: string, entity: Entity): void {
6763
index.line(`export * from "./model/${lowerCaseFirst(name)}.model"`)

packages/hydra-cli/src/scaffold.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function scaffold(options: ScaffoldOptions): void {
3030
build: 'tsc',
3131
'db:create': 'hydra-cli db:create',
3232
'db:drop': 'hydra-cli db:drop',
33-
'db:create-migration': 'hydra-clo db:create-migration',
33+
'db:create-migration': 'hydra-cli db:create-migration',
3434
'db:migrate': 'hydra-cli db:migrate',
3535
'db:revert': 'hydra-cli db:revert',
3636
'db:reset':

packages/hydra-e2e-tests/docker-compose.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ services:
2727
- DB_PASS=postgres
2828
- DB_HOST=db
2929
- DB_PORT=5432
30-
- INDEXER_ENDPOINT_URL=http://hydra-indexer-gateway:8080/v1/graphql
30+
- INDEXER_ENDPOINT_URL=http://hydra-indexer-gateway:8087/v1/graphql
3131
- CHAIN_NODE=ws://node-template:9944
3232
- POLL_INTERVAL_MS=500 # refresh every second
3333
- DEBUG=hydra*
@@ -70,6 +70,7 @@ services:
7070
build:
7171
context: ../..
7272
target: indexer-gateway
73+
restart: always
7374
depends_on:
7475
- redis
7576
- db
@@ -83,6 +84,7 @@ services:
8384
DB_HOST: db
8485
DB_PORT: 5432
8586
HYDRA_INDEXER_STATUS_SERVICE: http://hydra-indexer-status-service:8081/status
87+
HASURA_GRAPHQL_SERVER_PORT: 8087
8688

8789
hydra-indexer-status-service:
8890
build:

packages/hydra-e2e-tests/test/api/indexer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { GqlClient } from './gql-client'
22

33
export const indexer = new GqlClient(
4-
'http://hydra-indexer-gateway:8080/v1/graphql'
4+
'http://hydra-indexer-gateway:8087/v1/graphql'
55
)
66

77
export async function indexerHead(): Promise<number> {

packages/hydra-indexer-gateway/metadata/actions.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ type Query {
33
}
44

55
type IndexerStatus {
6-
hydraVersion : String
6+
hydraVersion : String!
77
head : Int!
88
lastComplete : Int!
99
maxComplete : Int!

packages/hydra-processor/src/state/StateKeeper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export class StateKeeper implements IStateKeeper {
111111
manifest.indexerVersionRange
112112
)
113113
}
114-
validateIndexerVersion(this.indexerStatus.hydraVersion, '>=4 <5')
114+
validateIndexerVersion(this.indexerStatus.hydraVersion, '>=4')
115115

116116
const range = manifest.mappings.range
117117

0 commit comments

Comments
 (0)