Replace Psalm by PHPStan

Author: hlecorche

.github/workflows/tests.yml

@@ -83,6 +83,6 @@ jobs:
                 if: matrix.coding-standards
                 run: cat LICENSE |grep -E "\(c\) ([0-9]+\-)*`date +%G`"
 
-            -   name: Run Psalm
+            -   name: Run PHPStan
                 if: matrix.static-analysis
-                run: php vendor/bin/psalm --stats --output-format=github
+                run: php vendor/bin/phpstan --no-progress --error-format=github

composer.json

@@ -26,8 +26,8 @@
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.0",
-        "phpunit/phpunit": "^8.4",
-        "vimeo/psalm": "^4.23"
+        "phpstan/phpstan": "^1.9",
+        "phpunit/phpunit": "^8.4"
     },
     "config": {
         "sort-packages": true

phpstan-baseline.neon

@@ -0,0 +1,5 @@
+parameters:
+    ignoreErrors:
+        -
+            message: '#no value type specified in iterable type array#'
+            path: tests/

phpstan.neon.dist

@@ -0,0 +1,9 @@
+includes:
+    - phpstan-baseline.neon
+    - vendor/phpstan/phpstan/conf/bleedingEdge.neon
+
+parameters:
+    level: max
+    paths:
+        - src
+        - tests

psalm.xml

@@ -15,6 +15,9 @@
 
 class ScalarValues
 {
+    /**
+     * @param array<mixed> $array
+     */
     public static function containsOnlyScalarValues(array $array): bool
     {
         foreach ($array as $child) {
@@ -26,6 +29,11 @@ public static function containsOnlyScalarValues(array $array): bool
         return true;
     }
 
+    /**
+     * @param array<mixed> $array
+     *
+     * @return array<scalar>
+     */
     public static function filterScalarValues(array $array): array
     {
         return array_filter($array, fn ($child) => \is_scalar($child));

src/ScalarValues.php

@@ -21,7 +21,7 @@ class ScalarValuesTest extends TestCase
     /**
      * @dataProvider getTestContainsOnlyScalarValuesProdiver
      */
-    public function testContainsOnlyScalarValues($input, $expected): void
+    public function testContainsOnlyScalarValues(array $input, bool $expected): void
     {
         $this->assertEquals(
             $expected,
@@ -49,12 +49,14 @@ public function getTestContainsOnlyScalarValuesProdiver(): array
     }
 
     /**
+     * @param mixed $input
+     *
      * @dataProvider getNotArrayInputProdiver
      */
     public function testContainsOnlyScalarValuesInputError($input): void
     {
         $this->expectException(\TypeError::class);
-        ScalarValues::containsOnlyScalarValues($input);
+        ScalarValues::containsOnlyScalarValues($input); // @phpstan-ignore-line
     }
 
     public function getNotArrayInputProdiver(): array
@@ -71,7 +73,7 @@ public function getNotArrayInputProdiver(): array
     /**
      * @dataProvider getTestFilterScalarValuesProdiver
      */
-    public function testFilterScalarValues($input, $expected): void
+    public function testFilterScalarValues(array $input, array $expected): void
     {
         $this->assertEquals(
             $expected,
@@ -99,11 +101,13 @@ public function getTestFilterScalarValuesProdiver(): array
     }
 
     /**
+     * @param mixed $input
+     *
      * @dataProvider getNotArrayInputProdiver
      */
     public function testFilterScalarValuesInputError($input): void
     {
         $this->expectException(\TypeError::class);
-        ScalarValues::filterScalarValues($input);
+        ScalarValues::filterScalarValues($input); // @phpstan-ignore-line
     }
 }