Skip to content

Commit 3f61588

Browse files
committed
cran comments and updated Rbuildignore
1 parent 71548ec commit 3f61588

File tree

2 files changed

+9
-22
lines changed

2 files changed

+9
-22
lines changed

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,4 @@
2222
^vignettes/media$
2323
^CRAN-SUBMISSION$
2424
^vignettes/.quarto$
25+
^revdep$

cran-comments.md

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,15 @@
1-
## Resubmission
1+
## Update to 0.2.0
22

3-
This is a resubmission. In this version I have:
3+
Brings new functions based on very quick user feedback after the first release.
44

5-
* Fixed removed the broken link in URI: vignettes/rJavaEnv.Rmd from: README.md
5+
# rJavaEnv 0.2.0 (2024-08-28)
66

7-
This is a resubmission. In this version I have:
7+
* Breaking change: `java_check_version_cmd()` and `java_check_version_rjava()` now return detected `Java` version instead of `TRUE`/`FALSE`
88

9-
* As per CRAN reviewer's request, added single quotes to all package, software and API names in the package title and package description.
9+
* New function `use_java()` to download, install and set `Java` from cache for the current sesssion, without touching the current project/working directory. This is intended for use with `targets` and `callr`.
1010

11-
* As per CRAN reviewer's request, revised the logic of the functions, examples and vignettes to not write to the user's home filespace by default. All examples use `tempdir()`. Also, like 'renv' ( https://github.com/rstudio/renv/blob/d6bced36afa0ad56719ca78be6773e9b4bbb078f/R/init.R#L69-L86 ), the package checks if user has previously consented to writing to the their home space on every run of a function that might result in writing something to the user's home filespace.
11+
* New vignette on using the package with `targets' and 'callr`
1212

13-
* Speficically, as per CRAN reviewer's instructions, I have changed the functions in `R/java_env.R`. `java_env_set()` now only changes the environemnt variables in current session by default. Other functions in this file would only change any files in the current project or any other non-temp directory only if instructed by the user.
13+
* Updated documentation with clearer instructions on cache folder cleanup before removing the package
1414

15-
* Created a global option `rJavaEnv.cache_path` to set the cache folder for downloaded Java installations. The default cache is in `tools::R_user_dir("rJavaEnv", which = "cache")`, just like in `renv` ( https://github.com/rstudio/renv/blob/d6bced36afa0ad56719ca78be6773e9b4bbb078f/R/bootstrap.R#L940-L950 ).
16-
17-
* With these safeguards, the pacakge will not download any files or write any data to either user space, current dir or even to the system cache in `tools::R_user_dir("rJavaEnv", which = "cache")`. However, keeping the default behaviour of the functions to act in the current directory is vital for the overall smooth experience that is similar to `renv`, which does not require the user to specify the target directory to act on every function run and, except for the first consent inquiry it does not ask the user where to keep the package cache. So the behavior of `rJavaEnv` mimics that of `renv` very closely to provide best user experience.
18-
19-
* Updated the vignettes. Switched vignettes to Quarto.
20-
21-
* Other minor code cleanups.
22-
23-
* I thank CRAN reviewers for the feedback on the initial submission, as it led to significant inmprovements in package design and stability.
24-
25-
## R CMD check results
26-
27-
0 errors | 0 warnings | 1 note
28-
29-
* This is a new release.
15+
* Depends on `R` > 4.0 to be able to write to the package cache directory without extra user warning. Cache cleanup and management functions are provided, as well as the documentation in both README and vignettes.

0 commit comments

Comments
 (0)