Change default new user login screen from "Label" screen, to the "Dashboard" screen

[sebastianbarry]

Currently, when a new user logs in for the first time, they are brought to the "Label" screen with no labels showing up. This looks like this:

Since there's no real text or images on this screen, users may get confused and think the app is not loading, or it is broken, as they are expecting to be put into some sort of "home" screen and they do not recognize this as being a home screen

Meanwhile the Dashboard looks like this

---

We want to change this to put the user into the dashboard once they finish the setup, so that they get more grounded more quickly once they open up the app

[sebastianbarry]

I could not find in the code where the initial app-open page is set. I found this section of the code:

www/js/splash/startprefs.js

startprefs.getNextState = function() {
      return startprefs.getPendingOnboardingState().then(function(result){
        if (result == null) {
          var temp = ReferralHandler.getReferralNavigation();
          if (temp == 'goals') {
            return {state: 'root.main.goals', params: {}};
          } else if ($rootScope.displayingIncident) {
            logger.log("Showing tripconfirm from startprefs");
            return {state: 'root.main.diary'};
          } else if (angular.isDefined($rootScope.redirectTo)) {
            var redirState = $rootScope.redirectTo;
            var redirParams = $rootScope.redirectParams;
            $rootScope.redirectTo = undefined;
            $rootScope.redirectParams = undefined;
            return {state: redirState, params: redirParams};
          } else {
            return {state: 'root.main.inf_scroll', params: {}};
          }
        } else {
          return {state: result, params: {}};
        }
      });
    };

    startprefs.loadPreferredScreen = function() {
      logger.log("About to navigate to preferred tab");
      startprefs.getNextState().then(changeState).catch(function(error) {
        logger.displayError("Error loading preferred tab, loading root.intro", error);
        // logger.log("error "+error+" loading finding tab, loading root.intro");
        changeState('root.intro');
      });
    };

And I found these commits associated in the Blame:

e-mission/e-mission-phone@095a5c3

e-mission/e-mission-phone@1648c95

But while placing breakpoints at this point in the code to try to figure out where the "label screen" is set as the initial open page, I did not see any text or variables set as "label screen" or anything related to the label screen

@shankari could you point me in the direction of the original commit/PR/Issue that relates to switching the initial app-open page from the dashboard to the label screen?

[sebastianbarry]

I completed this issue in this PR e-mission/e-mission-phone#880

Testing is in the PR