🦋 Changeset detected

Latest commit: c6c09f5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Hey @ValentaTomas, any reason this is not in the handleApiError / handle_api_exception method?

@mishushakov, I wasn't sure when looking at the new build endpoints that seem to sometimes return 404, but are using BuildError by default, if changing the error in the general error handler wouldn't break anything, + I wanted to have a nicer message there. We can generalize if it is 100% not a problem.

@ValentaTomas we aren't using BuildError by default. I have changed the implementation in the handler so it can use custom error class (SandboxError by default). I'd move any common error code here unless they're endpoint-specific.

export function handleApiError(
  response: FetchResponse<any, any, any>,
  errorClass: new (
    message: string,
    stackTrace?: string
  ) => Error = SandboxError,
  stackTrace?: string
)

you can throw all 404 as NotFoundException also, doesn't have to be Sandbox/Build error

Probably ok then. We might want to refine the server errors then (https://github.com/e2b-dev/infra/blob/add-client-proxy-retries/packages/api/internal/handlers/sandbox_get.go#L97 for example) if we are then exposing them via the general 404 handler.

@ValentaTomas we aren't using BuildError by default. I have changed the implementation in the handler so it can use custom error class (SandboxError by default). I'd move any common error code here unless they're endpoint-specific.

I know, but for example here (not sure if this specifically can return 404, but I found 404 in the API build handlers) if I add the explicit 404 general handler, this will now stop returning BuildError, but can return NotFoundError.

@ValentaTomas Same behavior as we have the with the AuthenticationError - it's not specific to Sandbox or Build.

@mishushakov I'm okay with that, but didn' want to break anything in the build system if you rely on this being BuildError anywhere.

404 status would be unexpected in Build system

404 status would be unexpected in Build system

Well, you can get that as the API can return that.

@mishushakov Ready for final check.