Skip to content

Commit 4d66499

Browse files
Chore: Remove unecessary debug logs (#184)
<!-- CURSOR_SUMMARY --> > [!NOTE] > Strips verbose debug logs and refactors team metadata retrieval from cookies, updating imports and a sign-in redirect usage. > > - **Server utils (`src/lib/utils/server.ts`)**: > - Replace `getTeamMetadataFromCookiesMemo`/cache flow with simplified `getTeamMetadataFromCookies` that directly validates cookie ID/slug. > - **Team resolution (`src/server/team/resolve-user-team.ts`)**: > - Use new `getTeamMetadataFromCookies` and remove debug logs; logic unchanged otherwise. > - **Routes**: > - `src/app/dashboard/account/route.ts`: remove debug logs; use `AUTH_URLS.SIGN_IN` constant for unauth redirect; preserve query params; set team cookies and redirect to resolved account settings. > - `src/app/dashboard/route.ts`: remove debug logs; unchanged redirect logic, still resolves team and redirects based on `tab`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6ac2f75. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 5dedf78 commit 4d66499

File tree

4 files changed

+16
-278
lines changed

4 files changed

+16
-278
lines changed

src/app/dashboard/account/route.ts

Lines changed: 1 addition & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,22 @@
11
import { AUTH_URLS, PROTECTED_URLS } from '@/configs/urls'
2-
import { l } from '@/lib/clients/logger/logger'
32
import { createClient } from '@/lib/clients/supabase/server'
43
import { encodedRedirect } from '@/lib/utils/auth'
54
import { setTeamCookies } from '@/lib/utils/cookies'
65
import { resolveUserTeam } from '@/server/team/resolve-user-team'
76
import { NextRequest, NextResponse } from 'next/server'
87

98
export async function GET(request: NextRequest) {
10-
l.debug(
11-
{
12-
key: 'account_route:start',
13-
url: request.url,
14-
},
15-
'account route - start'
16-
)
17-
189
const supabase = await createClient()
1910
const { data, error } = await supabase.auth.getUser()
2011

21-
l.debug(
22-
{
23-
key: 'account_route:user_auth',
24-
hasUser: !!data?.user,
25-
userId: data?.user?.id,
26-
hasError: !!error,
27-
},
28-
'account route - user auth'
29-
)
30-
3112
if (error || !data.user) {
32-
l.debug(
33-
{
34-
key: 'account_route:auth_redirect',
35-
redirectTo: '/sign-in',
36-
},
37-
'account route - auth redirect'
38-
)
39-
return NextResponse.redirect(new URL('/sign-in', request.url))
13+
return NextResponse.redirect(new URL(AUTH_URLS.SIGN_IN, request.url))
4014
}
4115

4216
// Resolve team for the user
4317
const team = await resolveUserTeam(data.user.id)
4418

4519
if (!team) {
46-
l.debug(
47-
{
48-
key: 'account_route:no_teams',
49-
userId: data.user.id,
50-
},
51-
'account route - no teams found, redirecting to sign-in'
52-
)
53-
5420
// UNEXPECTED STATE - sign out and redirect to sign-in
5521
await supabase.auth.signOut()
5622

@@ -63,16 +29,6 @@ export async function GET(request: NextRequest) {
6329
)
6430
}
6531

66-
l.debug(
67-
{
68-
key: 'account_route:team_resolved',
69-
teamId: team.id,
70-
teamSlug: team.slug,
71-
source: team.source,
72-
},
73-
'account route - team resolved'
74-
)
75-
7632
// Set team cookies for persistence
7733
await setTeamCookies(team.id, team.slug)
7834

@@ -87,14 +43,5 @@ export async function GET(request: NextRequest) {
8743
redirectUrl.searchParams.set(key, value)
8844
})
8945

90-
l.debug(
91-
{
92-
key: 'account_route:redirect',
93-
redirectPath: redirectUrl.toString(),
94-
teamIdentifier: team.slug || team.id,
95-
},
96-
'account route - redirecting to account settings'
97-
)
98-
9946
return NextResponse.redirect(redirectUrl)
10047
}

src/app/dashboard/route.ts

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { AUTH_URLS, PROTECTED_URLS } from '@/configs/urls'
2-
import { l } from '@/lib/clients/logger/logger'
32
import { createClient } from '@/lib/clients/supabase/server'
43
import { encodedRedirect } from '@/lib/utils/auth'
54
import { setTeamCookies } from '@/lib/utils/cookies'
@@ -24,51 +23,17 @@ export async function GET(request: NextRequest) {
2423
const searchParams = request.nextUrl.searchParams
2524
const tab = searchParams.get('tab')
2625

27-
l.debug(
28-
{
29-
key: 'dashboard_route:start',
30-
tab,
31-
url: request.url,
32-
},
33-
'dashboard route - start'
34-
)
35-
3626
const supabase = await createClient()
3727

3828
const { data, error } = await supabase.auth.getUser()
3929

40-
l.debug(
41-
{
42-
key: 'dashboard_route:user_auth',
43-
hasUser: !!data?.user,
44-
userId: data?.user?.id,
45-
hasError: !!error,
46-
},
47-
'dashboard route - user auth'
48-
)
49-
5030
if (error || !data.user) {
51-
l.debug(
52-
{
53-
key: 'dashboard_route:auth_redirect',
54-
redirectTo: '/sign-in',
55-
},
56-
'dashboard route - auth redirect'
57-
)
5831
return NextResponse.redirect(new URL('/sign-in', request.url))
5932
}
6033

6134
const team = await resolveUserTeam(data.user.id)
6235

6336
if (!team) {
64-
l.debug(
65-
{
66-
key: 'dashboard_route:no_teams',
67-
userId: data.user.id,
68-
},
69-
'dashboard route - no teams found, redirecting to sign-in'
70-
)
71-
7237
// UNEXPECTED STATE - sign out and redirect to sign-in
7338
await supabase.auth.signOut()
7439

@@ -81,16 +46,6 @@ export async function GET(request: NextRequest) {
8146
)
8247
}
8348

84-
l.debug(
85-
{
86-
key: 'dashboard_route:team_resolved',
87-
teamId: team.id,
88-
teamSlug: team.slug,
89-
source: team.source,
90-
},
91-
'dashboard route - team resolved'
92-
)
93-
9449
// Set team cookies for persistence
9550
await setTeamCookies(team.id, team.slug)
9651

@@ -100,15 +55,5 @@ export async function GET(request: NextRequest) {
10055
? urlGenerator(team.slug || team.id)
10156
: PROTECTED_URLS.SANDBOXES(team.slug || team.id)
10257

103-
l.debug(
104-
{
105-
key: 'dashboard_route:redirect',
106-
tab,
107-
redirectPath,
108-
teamIdentifier: team.slug || team.id,
109-
},
110-
'dashboard route - redirecting to tab'
111-
)
112-
11358
return NextResponse.redirect(new URL(redirectPath, request.url))
11459
}

src/lib/utils/server.ts

Lines changed: 13 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -46,105 +46,28 @@ export async function generateE2BUserAccessToken(supabaseAccessToken: string) {
4646
return res.data
4747
}
4848

49-
/**
50-
* Resolves team metadata from cookies.
51-
* If no metadata is found, it redirects to the dashboard.
52-
*/
53-
export const getTeamMetadataFromCookiesCache = cache(
54-
async (
55-
teamIdOrSlug: string,
56-
cookieTeamId: string,
57-
cookieTeamSlug: string
58-
) => {
59-
const isSensical =
60-
cookieTeamId === teamIdOrSlug || cookieTeamSlug === teamIdOrSlug
61-
const isUUID = z.uuid().safeParse(cookieTeamId).success
62-
63-
l.debug(
64-
{
65-
key: 'get_team_metadata_from_cookies:validation',
66-
teamIdOrSlug,
67-
cookieTeamId,
68-
cookieTeamSlug,
69-
isSensical,
70-
isUUID,
71-
},
72-
'validating team metadata'
73-
)
74-
75-
if (isUUID && isSensical) {
76-
l.debug(
77-
{
78-
key: 'get_team_metadata_from_cookies:success',
79-
teamIdOrSlug,
80-
cookieTeamId,
81-
cookieTeamSlug,
82-
},
83-
'successfully resolved team metadata from cookies'
84-
)
85-
return {
86-
id: cookieTeamId,
87-
slug: cookieTeamSlug,
88-
}
89-
}
90-
91-
l.debug(
92-
{
93-
key: 'get_team_metadata_from_cookies:invalid_data',
94-
teamIdOrSlug,
95-
cookieTeamId,
96-
cookieTeamSlug,
97-
isSensical,
98-
isUUID,
99-
},
100-
'invalid team data, returning null'
101-
)
102-
return null
103-
}
104-
)
105-
106-
export const getTeamMetadataFromCookiesMemo = async (teamIdOrSlug: string) => {
49+
export const getTeamMetadataFromCookies = async (teamIdOrSlug: string) => {
10750
const cookiesStore = await cookies()
10851

109-
l.debug(
110-
{
111-
key: 'get_team_metadata_from_cookies:start',
112-
cookiesStore: cookiesStore.getAll(),
113-
},
114-
'resolving team metadata from cookies'
115-
)
116-
11752
const cookieTeamId = cookiesStore.get(COOKIE_KEYS.SELECTED_TEAM_ID)?.value
11853
const cookieTeamSlug = cookiesStore.get(COOKIE_KEYS.SELECTED_TEAM_SLUG)?.value
11954

120-
l.debug(
121-
{
122-
key: 'get_team_metadata_from_cookies:start',
123-
hasId: !!cookieTeamId,
124-
hasSlug: !!cookieTeamSlug,
125-
cookieTeamId,
126-
cookieTeamSlug,
127-
},
128-
'resolving team metadata from cookies'
129-
)
130-
13155
if (!cookieTeamId || !cookieTeamSlug) {
132-
l.debug(
133-
{
134-
key: 'get_team_metadata_from_cookies:missing_data',
135-
hasId: !!cookieTeamId,
136-
hasSlug: !!cookieTeamSlug,
137-
},
138-
'missing team data in cookies, returning null'
139-
)
14056
return null
14157
}
14258

143-
return getTeamMetadataFromCookiesCache(
144-
teamIdOrSlug,
145-
cookieTeamId,
146-
cookieTeamSlug
147-
)
59+
const isSensical =
60+
cookieTeamId === teamIdOrSlug || cookieTeamSlug === teamIdOrSlug
61+
const isUUID = z.uuid().safeParse(cookieTeamId).success
62+
63+
if (isUUID && isSensical) {
64+
return {
65+
id: cookieTeamId,
66+
slug: cookieTeamSlug,
67+
}
68+
}
69+
70+
return null
14871
}
14972

15073
/**

0 commit comments

Comments
 (0)