fix: enhance build logs fetching and display logic

Author: ben-fornefeld

src/features/dashboard/build/build-logs-store.ts

@@ -171,15 +171,14 @@ export const createBuildLogsStore = () =>
           const cursor =
             state.backwardsCursor ?? state.getOldestTimestamp() ?? Date.now()
 
-          const result = await state._trpcClient.builds.buildLogsBackwards.query(
-            {
+          const result =
+            await state._trpcClient.builds.buildLogsBackwards.query({
               teamIdOrSlug: state._params.teamIdOrSlug,
               templateId: state._params.templateId,
               buildId: state._params.buildId,
               level: state.level ?? undefined,
               cursor,
-            }
-          )
+            })
 
           // Ignore stale response if init was called during fetch
           if (get()._initVersion !== requestVersion) {
@@ -207,11 +206,7 @@ export const createBuildLogsStore = () =>
       fetchMoreForwards: async () => {
         const state = get()
 
-        if (
-          !state._trpcClient ||
-          !state._params ||
-          state.isLoadingForwards
-        ) {
+        if (!state._trpcClient || !state._params || state.isLoadingForwards) {
           return { logsCount: 0 }
         }
 
@@ -240,15 +235,18 @@ export const createBuildLogsStore = () =>
             return { logsCount: 0 }
           }
 
+          let uniqueLogsCount = 0
+
           set((s) => {
             const uniqueNewLogs = deduplicateLogs(s.logs, result.logs)
-            if (uniqueNewLogs.length > 0) {
+            uniqueLogsCount = uniqueNewLogs.length
+            if (uniqueLogsCount > 0) {
               s.logs = [...s.logs, ...uniqueNewLogs]
             }
             s.isLoadingForwards = false
           })
 
-          return { logsCount: result.logs.length }
+          return { logsCount: uniqueLogsCount }
         } catch {
           if (get()._initVersion !== requestVersion) {
             return { logsCount: 0 }

src/features/dashboard/build/header-cells.tsx

@@ -73,21 +73,24 @@ export function RanFor({
     ? now - startedAt
     : (finishedAt ?? now) - startedAt
 
-  if (isBuilding) {
+  // no timestamp to copy - just show duration
+  if (isBuilding || !finishedAt) {
     return (
       <span className="whitespace-nowrap text-fg-tertiary">
         {formatDurationCompact(duration)}
       </span>
     )
   }
 
-  const iso = finishedAt ? new Date(finishedAt).toISOString() : null
-  const formattedTimestamp = finishedAt ? formatCompactDate(finishedAt) : null
+  const iso = new Date(finishedAt).toISOString()
+  const formattedTimestamp = formatCompactDate(finishedAt)
 
   return (
-    <CopyButtonInline value={iso ?? ''} className="whitespace-nowrap group/time">
+    <CopyButtonInline value={iso} className="whitespace-nowrap group/time">
       {formatDurationCompact(duration)}{' '}
-      <span className="text-fg-tertiary group-hover/time:text-current transition-colors">· {formattedTimestamp}</span>
+      <span className="text-fg-tertiary group-hover/time:text-current transition-colors">
+        · {formattedTimestamp}
+      </span>
     </CopyButtonInline>
   )
 }
@@ -100,7 +103,9 @@ export function StartedAt({ timestamp }: { timestamp: number }) {
   return (
     <CopyButtonInline value={iso} className="whitespace-nowrap group/time">
       {formatTimeAgoCompact(elapsed)}{' '}
-      <span className="text-fg-tertiary group-hover/time:text-current transition-colors">· {formattedTimestamp}</span>
+      <span className="text-fg-tertiary group-hover/time:text-current transition-colors">
+        · {formattedTimestamp}
+      </span>
     </CopyButtonInline>
   )
 }