Cleanup

Author: ValentaTomas

Makefile

@@ -3,12 +3,19 @@ ENV := $(shell cat ../../.last_used_env || echo "not-set")
 
 .PHONY: build
 build:
-	@versions_json=$$(./scripts/parse-versions-with-hash.sh firecracker_versions.txt); \
-	echo "$$versions_json" | jq -r '.[] | "\(.version)|\(.hash)|\(.version_name)"' | \
-	while IFS='|' read -r version hash version_name; do \
-		echo "Building $$version_name..."; \
-		./build.sh "$$version" "$$hash" "$$version_name"; \
-	done
+	@if ! git diff-index --quiet HEAD --; then \
+		echo "Error: Uncommitted changes detected. Please commit or stash changes before building." >&2; \
+		exit 1; \
+	fi
+	@hash=$$(git rev-parse HEAD); \
+	tag=$$(git describe --tags --abbrev=0 HEAD 2>/dev/null || echo ""); \
+	if [ -z "$$tag" ]; then \
+		echo "Error: No tag found for current commit" >&2; \
+		exit 1; \
+	fi; \
+	short_hash=$$(git rev-parse --short HEAD); \
+	version_name="$${tag}_$${short_hash}"; \
+	./build.sh "$$tag" "$$hash" "$$version_name"
 
 .PHONY: upload
 upload:

README.md

@@ -2,28 +2,45 @@
 
 ## Overview
 
-This project automates the building of custom Firecracker. It supports building specific firecracker versions and uploading the resulting binaries to a Google Cloud Storage (GCS) bucket.
+This project automates the building of custom Firecracker versions. It supports building specific firecracker versions and uploading the resulting binaries to a Google Cloud Storage (GCS) bucket.
 
 ## Prerequisites
 
 - Linux environment (for building firecracker)
+- Git repository with tags
 
 ## Building Firecrackers
 
-1. **Configure firecracker versions:**
-    - Edit `firecracker_versions.txt` to specify which firecracker versions to build (one per line, e.g., `<last_tag-prelease>-<first-8-letters-of-the-specific-commit>`).
+### Local Build
 
-2. **Build:**
+Build the current git version (latest tag + commit hash):
 
-   ```sh
-   make build
-   ```
+```sh
+make build
+```
 
-   The built firecrackers will be placed in `builds/<version_name>/firecracker`.
+**Requirements:**
+- The repository must be in a clean state (no uncommitted changes)
+- The current commit must have an associated tag
+- The built firecracker will be placed in `builds/<tag>_<shorthash>/firecracker`
 
-## Development Workflow
+### CI/CD Build
 
-- On every push, GitHub Actions will automatically build the firecrackers and save it as an artifact.
+The `firecracker_versions.txt` file specifies which versions to build in CI/CD:
+
+- Edit `firecracker_versions.txt` to specify firecracker versions (one per line)
+- Versions can be tags (e.g., `v1.10.1`) or tag with shorthash (e.g., `v1.12.1_abcdef12`)
+- On every push, GitHub Actions will automatically:
+  1. Parse versions from `firecracker_versions.txt` and resolve commit hashes
+  2. Build each version in parallel
+  3. Check CI status for each version
+  4. Upload successful builds to GCS and create GitHub releases (on main branch)
+
+## Scripts
+
+- `build.sh <version> <hash> <version_name>` - Builds a single Firecracker version
+- `scripts/parse-versions-with-hash.sh` - Parses versions and resolves commit hashes
+- `scripts/check-fc-ci.sh <versions_json>` - Checks CI status for parsed versions
 
 ## License