Pass domain to launchdarkly in API (#2004)

pass domain to launchdarkly in api

Author: djeebus

iac/provider-gcp/nomad/jobs/api.hcl

@@ -103,6 +103,7 @@ job "api" {
 
       env {
         ENVIRONMENT                    = "${environment}"
+        DOMAIN_NAME                    = "${domain_name}"
         NODE_ID                        = "$${node.unique.id}"
         NOMAD_TOKEN                    = "${nomad_acl_token}"
         ORCHESTRATOR_PORT              = "${orchestrator_port}"

iac/provider-gcp/nomad/main.tf

@@ -77,6 +77,7 @@ resource "nomad_job" "api" {
     memory_mb = var.api_resources_memory_mb
     cpu_count = var.api_resources_cpu_count
 
+    domain_name                             = var.domain_name
     orchestrator_port                       = var.orchestrator_port
     otel_collector_grpc_endpoint            = "localhost:${var.otel_collector_grpc_port}"
     logs_collector_address                  = "http://localhost:${var.logs_proxy_port.port}"

packages/api/internal/cfg/model.go

@@ -60,6 +60,8 @@ type Config struct {
 	// SandboxStorageBackend selects the sandbox storage implementation.
 	// "redis" uses Redis directly; "populate_redis" uses in-memory with Redis shadow writes.
 	SandboxStorageBackend string `env:"SANDBOX_STORAGE_BACKEND" envDefault:"memory"`
+
+	DomainName string `env:"DOMAIN_NAME" envDefault:""`
 }
 
 func Parse() (Config, error) {

packages/api/internal/handlers/store.go

@@ -130,6 +130,8 @@ func NewAPIStore(ctx context.Context, tel *telemetry.Client, config cfg.Config)
 		logger.L().Fatal(ctx, "failed to create feature flags client", zap.Error(err))
 	}
 
+	featureFlags.SetDeploymentName(config.DomainName)
+
 	accessTokenGenerator, err := sandbox.NewAccessTokenGenerator(config.SandboxAccessTokenHashSeed)
 	if err != nil {
 		logger.L().Fatal(ctx, "Initializing access token generator failed", zap.Error(err))

packages/orchestrator/internal/sandbox/uffd/userfaultfd/userfaultfd.go

@@ -374,7 +374,7 @@ func (u *Userfaultfd) faultPage(
 		span.RecordError(joinedErr)
 		u.logger.Error(ctx, "UFFD serve uffdio copy error", zap.Error(joinedErr))
 
-		return fmt.Errorf("failed uffdio copy %w", joinedErr)
+		return fmt.Errorf("failed uffdio copy: %w", joinedErr)
 	}
 
 	// Add the offset to the missing requests tracker with metadata.

packages/orchestrator/main.go

@@ -283,9 +283,7 @@ func run(config cfg.Config) (success bool) {
 	}
 	closers = append(closers, closer{"feature flags", featureFlags.Close})
 
-	if config.DomainName != "" {
-		featureFlags.SetDeploymentName(config.DomainName)
-	}
+	featureFlags.SetDeploymentName(config.DomainName)
 
 	// gcp concurrent upload limiter
 	limiter, err := limit.New(ctx, featureFlags)