linting and fixes

Author: djeebus

packages/orchestrator/pkg/sandbox/block/cache.go

@@ -516,13 +516,7 @@ func (c *Cache) copyProcessMemory(
 				return fmt.Errorf("failed to read memory: expected %d bytes, got %d", segmentSize, n)
 			}
 
-			startBlock := uint(header.BlockIdx(offset, c.blockSize))
-			endBlock := uint(header.BlockIdx(offset+segmentSize-1, c.blockSize))
-			c.dirtyMu.Lock()
-			for i := startBlock; i <= endBlock; i++ {
-				c.dirty.Set(i)
-			}
-			c.dirtyMu.Unlock()
+			c.setIsCached(offset, segmentSize)
 
 			offset += segmentSize
 

packages/orchestrator/pkg/sandbox/block/cache_bench_test.go

@@ -1,6 +1,7 @@
 package block
 
 import (
+	"fmt"
 	"os"
 	"testing"
 
@@ -30,7 +31,7 @@ func BenchmarkDirtyTracking(b *testing.B) {
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for i := range b.N {
 			// Simulate marking a block as cached
 			off := int64(i%262144) * blockSize
 			cache.setIsCached(off, blockSize)
@@ -39,14 +40,14 @@ func BenchmarkDirtyTracking(b *testing.B) {
 
 	b.Run("IsCached_Hit", func(b *testing.B) {
 		// Pre-populate some blocks as cached
-		for i := int64(0); i < 1000; i++ {
+		for i := range int64(1000) {
 			cache.setIsCached(i*blockSize, blockSize)
 		}
 
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for i := range b.N {
 			off := int64(i%1000) * blockSize
 			cache.isCached(off, blockSize)
 		}
@@ -56,7 +57,7 @@ func BenchmarkDirtyTracking(b *testing.B) {
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for i := range b.N {
 			// Check blocks that are definitely not cached (high offsets)
 			off := int64(100000+i%100000) * blockSize
 			cache.isCached(off, blockSize)
@@ -67,7 +68,7 @@ func BenchmarkDirtyTracking(b *testing.B) {
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for i := range b.N {
 			off := int64(i%262144) * blockSize
 			cache.WriteAt(data, off)
 		}
@@ -80,7 +81,7 @@ func BenchmarkDirtyTracking(b *testing.B) {
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for i := range b.N {
 			off := int64(i%65536) * blockSize * 4
 			cache.WriteAt(multiBlockData, off)
 		}
@@ -104,15 +105,15 @@ func BenchmarkDirtySortedKeys(b *testing.B) {
 	defer cache.Close()
 
 	// Mark 10% of blocks as dirty (26214 blocks)
-	for i := int64(0); i < 26214; i++ {
+	for i := range int64(26214) {
 		cache.setIsCached(i*blockSize, blockSize)
 	}
 
 	b.Run("DirtySortedKeys_10pct", func(b *testing.B) {
 		b.ReportAllocs()
 		b.ResetTimer()
 
-		for i := 0; i < b.N; i++ {
+		for range b.N {
 			keys := cache.dirtySortedKeys()
 			_ = keys
 		}
@@ -138,7 +139,7 @@ func BenchmarkCacheCreation(b *testing.B) {
 			b.ReportAllocs()
 			b.ResetTimer()
 
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				tmpFile := b.TempDir() + "/bench_cache"
 				cache, err := NewCache(size, blockSize, tmpFile, false)
 				if err != nil {
@@ -160,10 +161,10 @@ func formatSize(bytes int64) string {
 
 	switch {
 	case bytes >= GB:
-		return string(rune('0'+bytes/GB)) + "GB"
+		return fmt.Sprintf("%dGB", bytes/GB)
 	case bytes >= MB:
-		return string(rune('0'+bytes/MB)) + "MB"
+		return fmt.Sprintf("%dMB", bytes/MB)
 	default:
-		return string(rune('0'+bytes/KB)) + "KB"
+		return fmt.Sprintf("%dKB", bytes/KB)
 	}
 }

packages/orchestrator/pkg/sandbox/block/cache_dirty_test.go

@@ -82,7 +82,7 @@ func TestSetIsCached_ZeroLengthAtNonZeroOffset(t *testing.T) {
 	cache.setIsCached(blockSize*5, 0)
 
 	// No blocks should be marked as cached
-	for i := int64(0); i < 10; i++ {
+	for i := range int64(10) {
 		result := cache.isCached(i*blockSize, blockSize)
 		assert.False(t, result, "block %d should not be cached after zero-length setIsCached", i)
 	}
@@ -126,7 +126,7 @@ func TestWriteAt_PartiallyBeyondCacheSize(t *testing.T) {
 	assert.Equal(t, int(blockSize), n, "should only write up to cache size")
 
 	// Only block 9 should be marked as cached (the portion that fit)
-	for i := int64(0); i < 10; i++ {
+	for i := range int64(10) {
 		if i == 9 {
 			assert.True(t, cache.isCached(i*blockSize, blockSize), "block 9 should be cached")
 		} else {
@@ -161,7 +161,7 @@ func TestDirtyTracking_NormalOperation(t *testing.T) {
 	defer cache.Close()
 
 	// Initially nothing is cached
-	for i := int64(0); i < 10; i++ {
+	for i := range int64(10) {
 		assert.False(t, cache.isCached(i*blockSize, blockSize), "block %d should not be initially cached", i)
 	}
 
@@ -172,7 +172,7 @@ func TestDirtyTracking_NormalOperation(t *testing.T) {
 	assert.Equal(t, int(blockSize), n)
 
 	// Only block 3 should be cached
-	for i := int64(0); i < 10; i++ {
+	for i := range int64(10) {
 		if i == 3 {
 			assert.True(t, cache.isCached(i*blockSize, blockSize), "block 3 should be cached")
 		} else {
@@ -188,7 +188,7 @@ func TestDirtyTracking_NormalOperation(t *testing.T) {
 
 	// Blocks 3, 5, 6, 7 should be cached
 	expected := map[int64]bool{3: true, 5: true, 6: true, 7: true}
-	for i := int64(0); i < 10; i++ {
+	for i := range int64(10) {
 		if expected[i] {
 			assert.True(t, cache.isCached(i*blockSize, blockSize), "block %d should be cached", i)
 		} else {