Skip to content

Commit 6f0e7f7

Browse files
gets the alias for paused templates on GetSandboxesSandboxID
1 parent 64c3e19 commit 6f0e7f7

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

packages/api/internal/handlers/sandbox_get.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,8 @@ func (a *APIStore) GetSandboxesSandboxID(c *gin.Context, id string) {
200200
networkConfig = lastSnapshot.Snapshot.Config.Network
201201
}
202202

203+
pausedAlias := firstAlias(lastSnapshot.Aliases)
204+
203205
sandbox := api.SandboxDetail{
204206
ClientID: consts.ClientID, // for backwards compatibility we need to return a client id
205207
TemplateID: lastSnapshot.Snapshot.BaseEnvID,
@@ -218,6 +220,10 @@ func (a *APIStore) GetSandboxesSandboxID(c *gin.Context, id string) {
218220
Lifecycle: sandboxLifecycleToAPI(lastSnapshot.Snapshot.AutoPause, autoResumeConfig),
219221
}
220222

223+
if pausedAlias != "" {
224+
sandbox.Alias = &pausedAlias
225+
}
226+
221227
if lastSnapshot.Snapshot.Metadata != nil {
222228
metadata := api.SandboxMetadata(lastSnapshot.Snapshot.Metadata)
223229
sandbox.Metadata = &metadata

tests/integration/internal/tests/api/sandboxes/sandbox_detail_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ func TestSandboxDetailRunning(t *testing.T) {
3030
returnedSbx := response.JSON200
3131
assert.Equal(t, sbx.SandboxID, returnedSbx.SandboxID)
3232
assert.Equal(t, sbx.TemplateID, returnedSbx.TemplateID)
33+
require.NotNil(t, returnedSbx.Alias)
34+
assert.Equal(t, "base", *returnedSbx.Alias)
3335
}
3436

3537
func TestSandboxDetailReturnsLifecycleAndNetworkConfig(t *testing.T) {
@@ -100,6 +102,8 @@ func TestSandboxDetailPaused(t *testing.T) {
100102
returnedSbx := response.JSON200
101103
assert.Equal(t, sbx.SandboxID, returnedSbx.SandboxID)
102104
assert.Equal(t, sbx.TemplateID, returnedSbx.TemplateID)
105+
require.NotNil(t, returnedSbx.Alias)
106+
assert.Equal(t, "base", *returnedSbx.Alias)
103107
}
104108

105109
func TestSandboxDetailPausingSandbox(t *testing.T) {

0 commit comments

Comments
 (0)