fix: fire created_volume PostHog event before token generation (#2283)

Co-authored-by: djeebot <djeebot@users.noreply.github.com>
Co-authored-by: Joe Lombrozo <joe.lombrozo@e2b.dev>

Author: 3 people

packages/api/internal/handlers/volume_create.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/gin-gonic/gin"
 	"github.com/google/uuid"
-	"github.com/posthog/posthog-go"
 
 	"github.com/e2b-dev/infra/packages/api/internal/api"
 	"github.com/e2b-dev/infra/packages/api/internal/clusters"
@@ -141,6 +140,14 @@ func (a *APIStore) PostVolumes(c *gin.Context) {
 		return
 	}
 
+	a.posthog.IdentifyAnalyticsTeam(ctx, team.ID.String(), team.Name)
+	properties := a.posthog.GetPackageToPosthogProperties(&c.Request.Header)
+	a.posthog.CreateAnalyticsTeamEvent(ctx, team.ID.String(), "created_volume", properties.
+		Set("volume_id", volume.ID.String()).
+		Set("volume_name", volume.Name).
+		Set("volume_type", volumeType),
+	)
+
 	token, err := generateVolumeContentToken(a.config.VolumesToken, volume, team)
 	if err != nil {
 		a.sendAPIStoreError(c, http.StatusInternalServerError, "Volume created, but failed to generate volume content token")
@@ -149,12 +156,6 @@ func (a *APIStore) PostVolumes(c *gin.Context) {
 		return
 	}
 
-	a.posthog.CreateAnalyticsTeamEvent(ctx, team.ID.String(), "created_volume", posthog.NewProperties().
-		Set("volume_id", volume.ID.String()).
-		Set("volume_name", volume.Name).
-		Set("volume_type", volumeType),
-	)
-
 	result := api.VolumeAndToken{
 		VolumeID: volume.ID.String(),
 		Name:     volume.Name,