Skip to content

Commit 3dd6fb1

Browse files
committed
fix argo configs
1 parent bf2c626 commit 3dd6fb1

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

pipelines/base/aws-configurations-patch.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ metadata:
55
data:
66
config: |
77
{
8-
namespace: $(namespace),
8+
namespace: $(kfp-namespace),
99
artifactRepository:
1010
{
1111
archiveLogs: true,
1212
s3: {
1313
bucket: $(artifactRepositoryBucket),
1414
keyPrefix: $(artifactRepositoryKeyPrefix),
1515
endpoint: s3.amazonaws.com,
16-
region: ap-southeast-1
16+
region: $(awsRegion),
1717
insecure: false
1818
}
1919
}
@@ -68,6 +68,8 @@ spec:
6868
# management taking precedence of env vars over config.json
6969
# currently, minio client will init a static client if access keys and secret
7070
# are not empty.
71+
- $patch: delete
72+
name: OBJECTSTORECONFIG_BUCKETNAME
7173
- $patch: delete
7274
name: OBJECTSTORECONFIG_ACCESSKEY
7375
- $patch: delete

pipelines/overlay/accesskey/aws-configurations-patch.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@ apiVersion: v1
22
kind: ConfigMap
33
metadata:
44
name: workflow-controller-configmap
5-
namespace: kubeflow
65
data:
76
config: |
87
{
9-
executorImage: $(executorImage),
8+
namespace: $(kfp-namespace),
109
artifactRepository:
1110
{
1211
archiveLogs: true,
1312
s3: {
1413
bucket: $(artifactRepositoryBucket),
1514
keyPrefix: $(artifactRepositoryKeyPrefix),
1615
endpoint: s3.amazonaws.com,
16+
region: $(awsRegion),
1717
insecure: false,
1818
accessKeySecret: {
1919
name: $(awsSecretName),

0 commit comments

Comments
 (0)