Skip to content

Commit 99eae35

Browse files
committed
update to support kfp v1.0.0
1 parent bc0e5ab commit 99eae35

File tree

9 files changed

+60
-17
lines changed

9 files changed

+60
-17
lines changed

pipelines/base/aws-configurations-patch.yaml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
data:
66
config: |
77
{
8-
namespace: $(NAMESPACE),
8+
namespace: $(namespace),
99
artifactRepository:
1010
{
1111
archiveLogs: true,
@@ -62,10 +62,17 @@ spec:
6262
containers:
6363
- name: ml-pipeline-api-server
6464
env:
65-
- name: OBJECTSTORECONFIG_SECURE
66-
value: "true"
67-
- name: OBJECTSTORECONFIG_BUCKETNAME
68-
value: $(pipelineBucket)
65+
# we do not use minio related access key options, delete these
66+
# env vars as it interferes with config.json settings due to viper config
67+
# management taking precedence of env vars over config.json
68+
# currently, minio client will init a static client if access keys and secret
69+
# are not empty.
70+
- $patch: delete
71+
name: OBJECTSTORECONFIG_ACCESSKEY
72+
- $patch: delete
73+
name: OBJECTSTORECONFIG_SECRETACCESSKEY
74+
- $patch: delete
75+
name: OBJECTSTORECONFIG_SECURE
6976
- name: DBCONFIG_USER
7077
valueFrom:
7178
secretKeyRef:

pipelines/base/kustomization.yaml

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
33

44
bases:
5-
- github.com/kubeflow/pipelines//manifests/kustomize/base?ref=0.5.1
5+
- github.com/kubeflow/pipelines/manifests/kustomize/base?ref=1.0.0
66

77
resources:
88
# use a custom podTemplate definition for tensorboard viewer
@@ -20,7 +20,7 @@ patchesStrategicMerge:
2020

2121
configMapGenerator:
2222
# Note: pipeline-install-config is used by official kubeflow for installation parameters.
23-
# See: https://github.com/kubeflow/pipelines/blob/0.5.1/manifests/kustomize/base/kustomization.yaml
23+
# See: https://github.com/kubeflow/pipelines/blob/1.0.0/manifests/kustomize/base/kustomization.yaml
2424
# Create your own if you want to overwrite those parameters
2525
- name: pipeline-aws-parameters
2626
env: params.env # All parameters can be set inside this file
@@ -111,6 +111,41 @@ vars:
111111
apiVersion: v1
112112
fieldref:
113113
fieldpath: data.groupConcatMaxLen
114+
- name: dbHost
115+
objref:
116+
kind: ConfigMap
117+
name: pipeline-install-config
118+
apiVersion: v1
119+
fieldref:
120+
fieldpath: data.dbHost
121+
- name: dbPort
122+
objref:
123+
kind: ConfigMap
124+
name: pipeline-install-config
125+
apiVersion: v1
126+
fieldref:
127+
fieldpath: data.dbPort
128+
- name: mlmdDb
129+
objref:
130+
kind: ConfigMap
131+
name: pipeline-install-config
132+
apiVersion: v1
133+
fieldref:
134+
fieldpath: data.mlmdDb
135+
- name: cacheDb
136+
objref:
137+
kind: ConfigMap
138+
name: pipeline-install-config
139+
apiVersion: v1
140+
fieldref:
141+
fieldpath: data.cacheDb
142+
- name: pipelineDb
143+
objref:
144+
kind: ConfigMap
145+
name: pipeline-install-config
146+
apiVersion: v1
147+
fieldref:
148+
fieldpath: data.pipelineDb
114149

115150
configurations:
116151
- params.yaml

pipelines/base/manifest/ml-pipeline-apiserver-configmap.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,22 @@ data:
88
config.json: |
99
{
1010
"DBConfig": {
11-
"Host": "$(DBSERVICE_HOST)",
11+
"Host": "$(dbHost)",
1212
"Port": "3306",
1313
"DriverName": "mysql",
1414
"DataSourceName": "",
15-
"DBName": "$(DBNAME_PIPELINE)",
15+
"DBName": "$(pipelineDb)",
1616
"GroupConcatMaxLen": "$(groupConcatMaxLen)"
1717
},
1818
"ObjectStoreConfig": {
1919
"Host": "s3.amazonaws.com",
2020
"Region": "$(awsRegion)",
2121
"Secure": true,
22-
"BucketName": "$(pipelineBucket)",
22+
"BucketName": "$(artifactRepositoryBucket)",
2323
"PipelineFolder": "$(pipelinePath)",
24-
"PipelinePath": "$(pipelinePath)"
24+
"PipelinePath": "$(pipelinePath)",
25+
"AccessKey": "",
26+
"SecretAccessKey": ""
2527
},
2628
"InitConnectionTimeout": "6m",
2729
"DefaultPipelineRunnerServiceAccount": "pipeline-runner"

pipelines/base/manifest/mysql.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ spec:
2121
- name: mysql
2222
env:
2323
- name: MYSQL_DATABASES
24-
value: "$(DBNAME_PIPELINE),$(DBNAME_MLMD),$(DBNAME_CACHE)"
24+
value: "$(pipelineDb),$(mlmdDb),$(cacheDb)"
2525
- name: MYSQL_ROOT_PASSWORD
2626
valueFrom:
2727
secretKeyRef:
@@ -64,7 +64,7 @@ kind: Service
6464
metadata:
6565
labels:
6666
app: mysql
67-
name: $(DBSERVICE_HOST)
67+
name: $(dbHost)
6868
spec:
6969
selector:
7070
app: mysql

pipelines/base/params.env

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ mysqlStorageSize=20Gi
55
awsRegion=ap-southeast-1
66
artifactRepositoryBucket=mlpipeline
77
artifactRepositoryKeyPrefix=artifacts
8-
pipelineBucket=mlpipeline
98
pipelinePath=pipelines
109
groupConcatMaxLen=4194304

pipelines/base/params.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,5 @@ varReference:
2727
kind: StorageClass
2828
- path: metadata/name
2929
kind: Service
30+
- path: spec/ports/port
31+
kind: Service

pipelines/cluster-scoped-resources/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
33

44
bases:
5-
- github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=0.5.1
5+
- github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=1.0.0

pipelines/overlay/accesskey/params.env

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ awsAccessKeySecretKey=accesskey
88
awsSecretKeySecretKey=secretkey
99
artifactRepositoryBucket=mlpipeline
1010
artifactRepositoryKeyPrefix=artifacts
11-
pipelineBucket=mlpipeline
1211
pipelinePath=pipelines

pipelines/overlay/iam/params.env

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ awsIAMAnnotationKey=iam.amazonaws.com/role
77
awsIAMRole=kube2iam-role
88
artifactRepositoryBucket=mlpipeline
99
artifactRepositoryKeyPrefix=artifacts
10-
pipelineBucket=mlpipeline
1110
pipelinePath=pipelines

0 commit comments

Comments
 (0)