Skip to content

Commit 6677415

Browse files
authored
Add submit_io_batch changes. (#97)
Submit the io batch, which is a mandatory method to be called if read/write are issued with part_of_batch is set to true. In those cases, without this method, IOs might not be even issued. No-op if previous io requests are not part of batch.
1 parent 4628b6a commit 6677415

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

conanfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
class HomeBlocksConan(ConanFile):
1111
name = "homeblocks"
12-
version = "1.0.17"
12+
version = "1.0.18"
1313
homepage = "https://github.com/eBay/HomeBlocks"
1414
description = "Block Store built on HomeStore"
1515
topics = ("ebay")
@@ -43,7 +43,7 @@ def build_requirements(self):
4343
self.test_requires("gtest/1.14.0")
4444

4545
def requirements(self):
46-
self.requires("homestore/[~6.13]@oss/master", transitive_headers=True)
46+
self.requires("homestore/[~6.14]@oss/master", transitive_headers=True)
4747
self.requires("iomgr/[^11.3]@oss/master", transitive_headers=True)
4848
self.requires("sisl/[^12.2]@oss/master", transitive_headers=True)
4949
self.requires("lz4/1.9.4", override=True)

src/lib/homeblks_impl.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ class HomeBlocksImpl : public HomeBlocks, public VolumeManager, public std::enab
111111

112112
NullAsyncResult unmap(const VolumePtr& vol, const vol_interface_req_ptr& req) final;
113113

114+
// Submit the io batch, which is a mandatory method to be called if read/write are issued
115+
// with part_of_batchis set to true.
114116
void submit_io_batch() final;
115117

116118
// see api comments in base class;

src/lib/volume_mgr.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ VolumeManager::NullAsyncResult HomeBlocksImpl::unmap(const VolumePtr& vol, const
257257
return folly::Unit();
258258
}
259259

260-
void HomeBlocksImpl::submit_io_batch() { RELEASE_ASSERT(false, "submit_io_batch Not implemented"); }
260+
void HomeBlocksImpl::submit_io_batch() { homestore::data_service().submit_io_batch(); }
261261

262262
void HomeBlocksImpl::on_write(int64_t lsn, const sisl::blob& header, const sisl::blob& key,
263263
const std::vector< homestore::MultiBlkId >& new_blkids,

0 commit comments

Comments
 (0)