fix: ensure floating UI has loaded before using its functions (#560)

LuLaValva · web-flow · commit 04b3b125a695 · 2026-03-11T10:43:00.000-07:00
diff --git a/.changeset/wide-symbols-pull.md b/.changeset/wide-symbols-pull.md
@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+Fix floating UI loading bug
diff --git a/packages/ebayui-core/src/common/dropdown/index.ts b/packages/ebayui-core/src/common/dropdown/index.ts
@@ -72,6 +72,7 @@ export class DropdownUtil {
     }
 
     update() {
+        if (!this.loaded) return;
         const middleware = [] as Middleware[];
         middleware.push(this.offset(this.options.offset ?? 4));
         if (this.options.flip) {
diff --git a/packages/ebayui-core/src/components/components/ebay-tooltip-base/component-browser.ts b/packages/ebayui-core/src/components/components/ebay-tooltip-base/component-browser.ts
@@ -171,6 +171,7 @@ class TooltipBase extends Marko.Component<Input, State> {
     }
 
     updateTip() {
+        if (!this.state.loaded) return;
         this.computePosition(
             this.hostEl as HTMLElement,
             this.overlayEl as HTMLElement,

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@ebay/ebayui-core": patch
 +---
++
 +Fix floating UI loading bug
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ export class DropdownUtil {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`update() {`
	`75`	`+ if (!this.loaded) return;`
`75`	`76`	`const middleware = [] as Middleware[];`
`76`	`77`	`middleware.push(this.offset(this.options.offset ?? 4));`
`77`	`78`	`if (this.options.flip) {`
Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,7 @@ class TooltipBase extends Marko.Component<Input, State> {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`updateTip() {`
	`174`	`+ if (!this.state.loaded) return;`
`174`	`175`	`this.computePosition(`
`175`	`176`	`this.hostEl as HTMLElement,`
`176`	`177`	`this.overlayEl as HTMLElement,`