You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(adr): restore Percy automation context and tradeoffs
Reintroduce the original operational context and implementation details for Percy automation, including partial PR builds, full main builds, and metadata-based dependency tracking. Capture the key cost, speed, and maintenance tradeoffs without duplicating rationale across sections.
Co-authored-by: Cursor <cursoragent@cursor.com>
Copy file name to clipboardExpand all lines: docs/adr/0003-visual-regression-testing-tool.md
+17-11Lines changed: 17 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,7 +8,7 @@ Accepted
8
8
9
9
## Context
10
10
11
-
We need visual regression testing to catch unintended UI changes across our component library. With approximately 990 visual snapshots across our components, we needed to evaluate different visual regression testing tools to determine the best fit for our needs.
11
+
We need visual regression testing to catch unintended UI changes across our component library. We have approximately 990 snapshots, and Percy snapshots were previously executed manually. That process was paused because full runs were costly and slow, and running the full suite for every PR was not sustainable.
12
12
13
13
The primary options considered were:
14
14
@@ -18,26 +18,32 @@ The primary options considered were:
18
18
19
19
## Decision
20
20
21
-
We will use Percy for visual regression testing.
21
+
We will use Percy for visual regression testing and run it through automated GitHub Actions with partial builds for PRs and full builds on `main`.
22
22
23
-
Key factors in this decision:
23
+
Implementation approach:
24
24
25
-
1.**Existing infrastructure**: We already have an existing Percy account, eliminating procurement and setup overhead
26
-
2.**Cross-browser testing**: Percy provides testing across multiple browsers (Chrome, Firefox, Safari, Edge), which visual-html does not natively support
27
-
3.**Accurate**: Percy has been found to be accurate in finding differences between snapshots. Some other tools tend to show a lot of false positive
28
-
4.**Cloud infrastructure**: Percy's cloud-based service provides a good UI to quickly see the visual differences and approve the build.
25
+
1.**Partial builds for PRs**: Run snapshots only for components affected by changed files, and run full builds only when global files change (tokens, variables, mixins).
26
+
2.**Full builds on `main`**: Run and auto-approve the complete snapshot suite for baseline coverage.
0 commit comments