Skip to content

Commit 9117681

Browse files
authored
fix(eek): add a11y docs, remove redundant aria-hidden (#524)
1 parent 72d5b59 commit 9117681

File tree

10 files changed

+218
-2612
lines changed

10 files changed

+218
-2612
lines changed

.changeset/gentle-moles-hide.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@ebay/ui-core-react": patch
3+
"@ebay/ebayui-core": patch
4+
---
5+
6+
fix(eek): add a11y docs, remove redundant aria-hidden

packages/ebayui-core-react/src/ebay-eek/eek-rating.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,11 @@ const EbayEek: FC<EbayEekProps> = ({ min = "", max = "", rating, a11yText, class
2020
<div className={className} role="figure" aria-label={a11yText || backupA11yText}>
2121
<div className="eek__container" aria-hidden>
2222
<span className="eek__rating-range">
23-
<span aria-hidden="true">{max}</span>
23+
<span>{max}</span>
2424
<EbayIconEekRangeArrow />
25-
<span aria-hidden="true">{min}</span>
26-
</span>
27-
<span className="eek__rating" aria-hidden="true">
28-
{rating}
25+
<span>{min}</span>
2926
</span>
27+
<span className="eek__rating">{rating}</span>
3028
</div>
3129
<EbayIconEekArrow />
3230
</div>

packages/ebayui-core/src/components/ebay-eek/index.marko

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ $ const eekRating = eekUtil(input);
2929
>
3030
<div class="eek__container" aria-hidden="true">
3131
<span class="eek__rating-range">
32-
<span aria-hidden="true">
32+
<span>
3333
${max}
3434
</span>
3535
<ebay-eek-range-arrow-icon/>
36-
<span aria-hidden="true">
36+
<span>
3737
${min}
3838
</span>
3939
</span>
40-
<span class="eek__rating" aria-hidden="true">
40+
<span class="eek__rating">
4141
${rating}
4242
</span>
4343
</div>

0 commit comments

Comments
 (0)