Skip to content

Commit 65dee75

Browse files
committed
return stable object for useModal
1 parent 7fa8bad commit 65dee75

File tree

1 file changed

+26
-12
lines changed

1 file changed

+26
-12
lines changed

src/index.tsx

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -356,18 +356,32 @@ export function useModal(modal?: any, args?: any): any {
356356
[mid],
357357
);
358358

359-
return {
360-
id: mid,
361-
args: modalInfo?.args,
362-
visible: !!modalInfo?.visible,
363-
keepMounted: !!modalInfo?.keepMounted,
364-
show: showCallback,
365-
hide: hideCallback,
366-
remove: removeCallback,
367-
resolve: resolveCallback,
368-
reject: rejectCallback,
369-
resolveHide,
370-
};
359+
return useMemo(
360+
() => ({
361+
id: mid,
362+
args: modalInfo?.args,
363+
visible: !!modalInfo?.visible,
364+
keepMounted: !!modalInfo?.keepMounted,
365+
show: showCallback,
366+
hide: hideCallback,
367+
remove: removeCallback,
368+
resolve: resolveCallback,
369+
reject: rejectCallback,
370+
resolveHide,
371+
}),
372+
[
373+
mid,
374+
modalInfo?.args,
375+
modalInfo?.visible,
376+
modalInfo?.keepMounted,
377+
showCallback,
378+
hideCallback,
379+
removeCallback,
380+
resolveCallback,
381+
rejectCallback,
382+
resolveHide,
383+
],
384+
);
371385
}
372386
export const create = <P extends {}>(
373387
Comp: React.ComponentType<P>,

0 commit comments

Comments
 (0)