Up version

Author: supnate

example/src/App.jsx

@@ -50,7 +50,7 @@ const examples = {
   },
   propsBinding: {
     name: 'Props Binding',
-    description: 'To bind props to modal, need to declare the modal using jsx.',
+    description: 'To bind props to modal, need to declare the modal using <ModalHolder />.',
     component: PropsBinding,
     code: ['PropsBinding.jsx'],
   },

example/src/TsTest.tsx

@@ -1,5 +1,5 @@
 // This a test file to check if typescript is working properly
-
+import React from 'react';
 import NiceModal, { useModal, antdModalV5 } from '@ebay/nice-modal-react';
 
 const MyModal1 = NiceModal.create(({ p1, p2 }: { p1: string; p2: number }) => {
@@ -22,16 +22,20 @@ const MyModal2 = NiceModal.create(() => {
   );
 });
 
-NiceModal.register('modal-1', MyModal1, { p2: 1 });
+NiceModal.register('modal-1', MyModal1, { p2: 1, p1: 'abc' });
 
 export default function TsTest() {
-  const modal1 = useModal(MyModal1, { p3: 'foo', p2: 123 });
+  const modal1 = useModal(MyModal1, { p1: 'abc', p2: 123 });
   modal1.show({ p1: 'foo', p2: 123, p4: 'hello' }); // expected: p4 should not be accepted
+  modal1.show({ p2: 1, p1: '1' });
+  modal1.show({ p2: 1, p1: 1 }); // expected: p1 should be string
+  modal1.show();
 
   NiceModal.show(MyModal1); // valid?
   NiceModal.show(MyModal1, { p1: 'foo', p2: 123 }); // valid
   NiceModal.show(MyModal1, { p1: 'foo', p2: '123' }); // expected ts error: p2 should be number
-  NiceModal.show(MyModal1, { p1: 'foo' }); // unexpected ts error: p2 is already set when register
+  NiceModal.show(MyModal1, { p1: 'foo' });
+  NiceModal.show(MyModal1, { p2: 123 });
 
   const modal1_1 = useModal('modal-1', { p3: 'foo', p2: 123 });
   modal1_1.show();

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ebay/nice-modal-react",
-  "version": "1.2.10",
+  "version": "1.2.11",
   "license": "MIT",
   "main": "./lib/cjs/index.js",
   "module": "./lib/esm/index.js",