Merge pull request #54 from janczizikow/feat/stable-handlers

supnate · web-flow · commit dcb75872660d · 2022-04-07T11:42:11.000+08:00
feat: flatten dependencies in useModal
diff --git a/src/index.tsx b/src/index.tsx
@@ -325,7 +325,7 @@ export function useModal(modal?: any, args?: any): any {
         delete hideModalCallbacks[mid];
       },
     }),
-    [mid, modalInfo],
+    [mid, modalInfo?.args, modalInfo?.keepMounted, modalInfo?.visible],
   );
 }
 export const create = <P extends Record<string, unknown>>(

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ export function useModal(modal?: any, args?: any): any {`
`325`	`325`	`delete hideModalCallbacks[mid];`
`326`	`326`	`},`
`327`	`327`	`}),`
`328`		`- [mid, modalInfo],`
	`328`	`+ [mid, modalInfo?.args, modalInfo?.keepMounted, modalInfo?.visible],`
`329`	`329`	`);`
`330`	`330`	`}`
`331`	`331`	`export const create = <P extends Record<string, unknown>>(`