make the destructor of obj life counter virtual for its destructor to be called when the derived class is destructed (#250)

raakella1 · Ravi Nagarjun Akella · web-flow · commit 481f7c6f159d · 2025-01-24T08:24:51.000-08:00
Co-authored-by: Ravi Nagarjun Akella &lt;raakella1@$HOSTNAME&gt;
diff --git a/conanfile.py b/conanfile.py
@@ -9,7 +9,7 @@
 
 class SISLConan(ConanFile):
     name = "sisl"
-    version = "8.9.0"
+    version = "8.9.1"
     homepage = "https://github.com/eBay/sisl"
     description = "Library for fast data structures, utilities"
     topics = ("ebay", "components", "core", "efficiency")
diff --git a/include/sisl/utility/obj_life_counter.hpp b/include/sisl/utility/obj_life_counter.hpp
@@ -140,7 +140,7 @@ struct ObjLifeCounter {
         s_type.m_dummy = 0; // To keep s_type initialized during compile time
     }
 
-    ~ObjLifeCounter() {
+    virtual ~ObjLifeCounter() {
         assert(s_alive.load() > 0);
         s_alive.fetch_sub(1, std::memory_order_relaxed);
     }

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ struct ObjLifeCounter {`
`140`	`140`	`s_type.m_dummy = 0; // To keep s_type initialized during compile time`
`141`	`141`	`}`
`142`	`142`
`143`		`- ~ObjLifeCounter() {`
	`143`	`+ virtual ~ObjLifeCounter() {`
`144`	`144`	`assert(s_alive.load() > 0);`
`145`	`145`	`s_alive.fetch_sub(1, std::memory_order_relaxed);`
`146`	`146`	`}`