generate coredump file for easier debug

Author: yawzhang

conanfile.py

@@ -9,7 +9,7 @@
 
 class SISLConan(ConanFile):
     name = "sisl"
-    version = "12.4.4"
+    version = "12.4.5"
 
     homepage = "https://github.com/eBay/sisl"
     description = "Library for fast data structures, utilities"

src/logging/stacktrace.cpp

@@ -37,6 +37,11 @@
 #else
 #include "stacktrace_release.h"
 #endif
+#include <sisl/options/options.h>
+
+
+SISL_OPTION_GROUP(stacktrace,
+                  (enable_core_dump, "", "enable_core_dump", "Generate coredump file when crash", ::cxxopts::value<bool>(), ""))
 
 namespace sisl {
 namespace logging {
@@ -81,11 +86,20 @@ static void exit_with_default_sighandler(const SignalType fatal_signal_id) {
                   << std::flush;
     }
 
-    //::kill(::getpid(), fatal_signal_id);
-    if (fatal_signal_id == SIGABRT) {
-        std::_Exit(fatal_signal_id);
+    // If core dump file generation is enabled and the signal is one that generates a core dump, re-raise the signal
+    const std::unordered_set<SignalType> core_dump_signals = {SIGABRT, SIGFPE, SIGSEGV, SIGILL};
+    if (SISL_OPTIONS["enable_core_dump"].count() && core_dump_signals.count(fatal_signal_id) > 0) {
+        std::cerr << "\n"
+                  << __FUNCTION__ << ":" << __LINE__ << ". Raising signal "
+                  << fatal_signal_id << "   \n\n"
+                  << std::flush;
+        std::raise(fatal_signal_id);
     } else {
-        std::exit(fatal_signal_id);
+        if (fatal_signal_id == SIGABRT) {
+            std::_Exit(fatal_signal_id);
+        } else {
+            std::exit(fatal_signal_id);
+        }
     }
 }