Build with warnings as errors (#289) (#290)

* Refs #23858. Build with warnings as errors.



* Refs #23858. Add option for MSVC



* Refs #23858. Fix warning.



* Refs #23858. Move to CI



* Apply suggestion




---------





(cherry picked from commit 9beec7e)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González <correoricky@gmail.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>

Author: 3 people

.github/workflows/reusable-ci.yml

@@ -53,6 +53,7 @@ on:
         type: boolean
         default: false
 env:
+    colcon-build-default-cmake-args: ${{ contains(inputs.os-version, 'windows') && '-DCMAKE_CXX_FLAGS_INIT="/WX"' || '-DCMAKE_CXX_FLAGS_INIT="-Werror"' }}
     toolset: ${{ inputs.vs-toolset && format('-T {0}', inputs.vs-toolset) || '' }}
 defaults:
   run:
@@ -122,7 +123,7 @@ jobs:
         colcon_build_args: ${{ inputs.colcon-args }}
         colcon_build_args_default: --event-handlers=console_direct+
         cmake_args: ${{ inputs.cmake-args }}
-        cmake_args_default: ${{ env.toolset }}
+        cmake_args_default: ${{ env.colcon-build-default-cmake-args }} ${{ env.toolset }}
         cmake_build_type: ${{ matrix.cmake-build-type }}
         workspace: ${{ github.workspace }}
 

test/cdr/SimpleTest.cpp

@@ -2265,7 +2265,7 @@ TEST(CDRTests, DeserializeIntoANonEmptyMapInXCDRv1)
     };
 
     std::map<uint16_t, std::string> initialized_map{
-        {1, "a"}
+        {static_cast<uint16_t>(1u), "a"}
     };
 
     FastBuffer cdr_buffer(buffer, 14);