Refs #23919. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Author: richiware

src/cpp/rtps/writer/ReaderProxy.cpp

@@ -227,9 +227,10 @@ void ReaderProxy::add_change(
         const ChangeForReader_t& change,
         bool is_relevant)
 {
-    assert(change.getSequenceNumber() > changes_low_mark_);
+    SequenceNumber_t seq_num {change.getSequenceNumber()};
+    assert(seq_num() > changes_low_mark_);
     assert(changes_for_reader_.empty() ? true :
-            change.getSequenceNumber() > changes_for_reader_.back().getSequenceNumber());
+            seq_num > changes_for_reader_.back().getSequenceNumber());
 
     // Irrelevant changes are not added to the collection
     if (!is_relevant)
@@ -240,26 +241,26 @@ void ReaderProxy::add_change(
             {
                 if (SequenceNumber_t::unknown() == first_irrelevant_removed_)
                 {
-                    first_irrelevant_removed_ = change.getSequenceNumber();
-                    last_irrelevant_removed_ = change.getSequenceNumber();
+                    first_irrelevant_removed_ = seq_num;
+                    last_irrelevant_removed_ = seq_num;
                 }
-                else if  (change.getSequenceNumber() == last_irrelevant_removed_ + 1)
+                else if  (seq_num == last_irrelevant_removed_ + 1)
                 {
-                    last_irrelevant_removed_ = change.getSequenceNumber();
+                    last_irrelevant_removed_ = seq_num;
                 }
             }
         }
-        else if (changes_low_mark_ + 1 == change.getSequenceNumber())
+        else if (changes_low_mark_ + 1 == seq_num)
         {
-            changes_low_mark_ = change.getSequenceNumber();
+            changes_low_mark_ = seq_num;
         }
         return;
     }
 
     if (changes_for_reader_.push_back(change) == nullptr)
     {
         // This should never happen
-        EPROSIMA_LOG_ERROR(RTPS_READER_PROXY, "Error adding change " << change.getSequenceNumber()
+        EPROSIMA_LOG_ERROR(RTPS_READER_PROXY, "Error adding change " << seq_num
                                                                      << " to reader proxy " << guid());
         eprosima::fastdds::dds::Log::Flush();
         assert(false);

src/cpp/rtps/writer/ReaderProxy.hpp

@@ -341,22 +341,22 @@ class ReaderProxy
      * Get the highest fully acknowledged sequence number.
      * @return the highest fully acknowledged sequence number.
      */
-    SequenceNumber_t changes_low_mark() const
+    inline SequenceNumber_t changes_low_mark() const
     {
         return changes_low_mark_;
     }
 
-    SequenceNumber_t first_irrelevant_removed() const
+    inline SequenceNumber_t first_irrelevant_removed() const
     {
         return first_irrelevant_removed_;
     }
 
-    SequenceNumber_t last_irrelevant_removed() const
+    inline SequenceNumber_t last_irrelevant_removed() const
     {
         return last_irrelevant_removed_;
     }
 
-    void reset_irrelevant_removed()
+    inline void reset_irrelevant_removed()
     {
         first_irrelevant_removed_ = SequenceNumber_t::unknown();
         last_irrelevant_removed_ = SequenceNumber_t::unknown();