Skip to content

Commit b8f4ce7

Browse files
mergify[bot]fujitatomoyaMiguelCompany
authored
Fix EDP reliability timings (#5540) (#5556)
* Fix EDP reliability timings (#5540) * EDP default configuration should be in milliseconds, not microseconds. Signed-off-by: Tomoya Fujita <[email protected]> * add the timeout for writer->wait_discovery(). Signed-off-by: Tomoya Fujita <[email protected]> * Refs #22537: test fix Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Mario Dominguez <[email protected]> (cherry picked from commit b53a389) # Conflicts: # src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp * Fix conflicts Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Miguel Company <[email protected]>
1 parent 7641f3d commit b8f4ce7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ namespace rtps {
5555

5656
// Default configuration values for EDP entities.
5757
static const Duration_t edp_heartbeat_period{1, 0}; // 1 second
58-
static const Duration_t edp_nack_response_delay{0, 100 * 1000 }; // 100 milliseconds
59-
static const Duration_t edp_nack_supression_duration{0, 10 * 1000}; // 10 milliseconds
60-
static const Duration_t edp_heartbeat_response_delay{0, 10 * 1000}; // 10 milliseconds
58+
static const Duration_t edp_nack_response_delay{0, 100 * 1000 * 1000 }; // 100 milliseconds
59+
static const Duration_t edp_nack_supression_duration{0, 10 * 1000 * 1000}; // 10 milliseconds
60+
static const Duration_t edp_heartbeat_response_delay{0, 10 * 1000 * 1000}; // 10 milliseconds
6161

6262
static const int32_t edp_reader_initial_reserved_caches = 1;
6363
static const int32_t edp_writer_initial_reserved_caches = 20;

test/blackbox/common/DDSBlackboxTestsStatistics.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@ TEST(DDSStatistics, correct_deletion_upon_delete_contained_entities)
765765
writer->init();
766766
ASSERT_TRUE(writer->isInitialized());
767767
writer->wait_discovery();
768-
writer->send(*data, 10);
768+
writer->send(*data, 200);
769769
writer->destroy();
770770
}));
771771

0 commit comments

Comments
 (0)