Skip to content

Commit ddd1016

Browse files
committed
Refs #23919. Apply suggestions
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
1 parent 0904cbf commit ddd1016

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

src/cpp/rtps/writer/ReaderProxy.hpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,16 +346,27 @@ class ReaderProxy
346346
return changes_low_mark_;
347347
}
348348

349+
/*!
350+
* Get the first sequence number not relevant that was removed without reader being informed.
351+
* @return First sequence number.
352+
*/
349353
inline SequenceNumber_t first_irrelevant_removed() const
350354
{
351355
return first_irrelevant_removed_;
352356
}
353357

358+
/*!
359+
* Get the last sequence number not relevant that was removed without reader being informed.
360+
* @return last sequence number.
361+
*/
354362
inline SequenceNumber_t last_irrelevant_removed() const
355363
{
356364
return last_irrelevant_removed_;
357365
}
358366

367+
/*!
368+
* Reset the interval of sequence numbers not relevant that were removed without reader being informed.
369+
*/
359370
inline void reset_irrelevant_removed()
360371
{
361372
first_irrelevant_removed_ = SequenceNumber_t::unknown();
@@ -462,6 +473,7 @@ class ReaderProxy
462473
//! Last NACKFRAG count.
463474
uint32_t last_nackfrag_count_;
464475

476+
//! Sequence number of the lowest change not fully acknowledged.
465477
SequenceNumber_t changes_low_mark_;
466478

467479
//! First sequence number not relevant that was removed without reader being informed.

src/cpp/rtps/writer/StatefulWriter.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,11 @@ class StatefulWriter : public BaseWriter
385385
*/
386386
bool ack_timer_expired();
387387

388+
/*!
389+
* Send heartbeat to all the remote readers.
390+
* @param force_separating True to send the heartbeat separately for each reader.
391+
* False to send a unique heartbeat to all the readers.
392+
*/
388393
void send_heartbeat_to_all_readers(
389394
bool force_separating);
390395

0 commit comments

Comments
 (0)