Added RPC tests and deleted request/replier tests

Signed-off-by: zesk1999 <zesk1999@gmail.com>

Author: zesk1999

sustainml_cpp/src/cpp/core/GenericServiceNodeImpl.hpp

@@ -61,9 +61,6 @@ class GenericServiceNodeImpl : public ServerBase
             throw ::InternalError("update_configuration: node is shutting down");
         }
 
-        std::cout << "[RPC SERVER/" << tag_ << "] update_configuration cfg='"
-                  << configuration << "'\n";
-
         types::RequestType req;
         types::ResponseType res;
 
@@ -77,12 +74,14 @@ class GenericServiceNodeImpl : public ServerBase
         {
             throw ::InternalError(std::string("update_configuration: ") + e.what());
         }
-        catch (...)
-        {
-            throw ::InternalError("update_configuration: unknown error");
-        }
 
-        return res.configuration();
+        // Copy into owned std::string
+        std::string reply = res.configuration();
+
+        std::cout << "[RPC SERVER/" << tag_
+                  << "] returning cfg='" << reply << "'\n";
+
+        return reply;   // Safe
     }
 
 private:

sustainml_cpp/test/blackbox/CMakeLists.txt

@@ -14,7 +14,6 @@
 
 
 file(GLOB BLACKBOXTESTS_TEST_SOURCE "common/BlackboxTests*.cpp")
-list(FILTER BLACKBOXTESTS_TEST_SOURCE EXCLUDE REGEX ".*ResponseNodes.*\\.cpp$") # Old behavior tests
 set(BLACKBOXTESTS_SOURCE ${BLACKBOXTESTS_TEST_SOURCE}
     ${PROJECT_SOURCE_DIR}/src/cpp/types/typesImplTypeObjectSupport.cxx
     ${PROJECT_SOURCE_DIR}/src/cpp/types/typesImplPubSubTypes.cxx

sustainml_cpp/test/blackbox/api/ManagedNode.hpp

@@ -133,7 +133,6 @@ class ManagedNode
     ~ManagedNode()
     {
         stop();
-        th_->join();
     }
 
     void start()
@@ -149,6 +148,11 @@ class ManagedNode
     void stop()
     {
         _NODE_TYPE::terminate();
+
+        if (th_ && th_->joinable())
+        {
+            th_->join();
+        }
     }
 
     void prepare_expected_samples(
@@ -198,4 +202,3 @@ class ManagedNode
 };
 
 #endif // _TEST_BLACKBOX_MANAGEDNODE_HPP_
-