test RECOMMENDED checks pass for valid crates

Author: elichad

tests/integration/profiles/five-safes-crate/test_valid_5src.py

@@ -13,7 +13,9 @@
 # limitations under the License.
 
 import logging
+import pytest
 
+from rocrate_validator import services
 from rocrate_validator.models import Severity
 from tests.conftest import SKIP_LOCAL_DATA_ENTITY_EXISTENCE_CHECK_IDENTIFIER
 from tests.ro_crates import ValidROC
@@ -22,6 +24,18 @@
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.DEBUG)
 
+# Dynamically fetch the SKIP_WEB_RESOURCE_AVAILABILITY_IDENTIFIER
+rocrate_profile = services.get_profile("ro-crate")
+if not rocrate_profile:
+    raise RuntimeError("Unable to load the RO-Crate profile")
+check_local_data_entity_existence = rocrate_profile.get_requirement_check(
+    "Web-based Data Entity: resource availability"
+)
+assert (
+    check_local_data_entity_existence
+), "Unable to find the requirement 'Web-based Data Entity: resource availability'"
+SKIP_WEB_RESOURCE_AVAILABILITY_IDENTIFIER = check_local_data_entity_existence.identifier
+
 
 def test_valid_five_safes_crate_request_required():
     """Test a valid Five Safes Crate representing a request."""
@@ -36,6 +50,27 @@ def test_valid_five_safes_crate_request_required():
     )
 
 
+@pytest.mark.xfail(
+    reason="""
+        Checks that ensure certain Five Safes actions are present currently fail for this crate,
+        as this crate represents an early stage of a process before those actions have happened.
+    """
+)
+def test_valid_five_safes_crate_request_recommended():
+    """Test a valid Five Safes Crate representing a request."""
+    do_entity_test(
+        ValidROC().five_safes_crate_request,
+        Severity.RECOMMENDED,
+        True,
+        profile_identifier="five-safes-crate",
+        skip_checks=[
+            SKIP_LOCAL_DATA_ENTITY_EXISTENCE_CHECK_IDENTIFIER,
+            SKIP_WEB_RESOURCE_AVAILABILITY_IDENTIFIER,
+        ],
+        disable_inherited_profiles_reporting=True,
+    )
+
+
 def test_valid_five_safes_crate_result_required():
     """Test a valid Five Safes Crate representing a result."""
     do_entity_test(
@@ -49,6 +84,21 @@ def test_valid_five_safes_crate_result_required():
     )
 
 
+def test_valid_five_safes_crate_result_recommended():
+    """Test a valid Five Safes Crate representing a result."""
+    do_entity_test(
+        ValidROC().five_safes_crate_result,
+        Severity.RECOMMENDED,
+        True,
+        profile_identifier="five-safes-crate",
+        skip_checks=[
+            SKIP_LOCAL_DATA_ENTITY_EXISTENCE_CHECK_IDENTIFIER,
+            SKIP_WEB_RESOURCE_AVAILABILITY_IDENTIFIER,
+        ],
+        disable_inherited_profiles_reporting=True,
+    )
+
+
 def test_valid_five_safes_crate_multiple_context():
     """Test a valid Five Safes Crate representing a result."""
     do_entity_test(