[enhancement] improve view module

- refactor for readability
- make use of newer templating features
  - filter templating attributes from rendered HTML
  - disallow legacy class-syntax
- remove unnecessary try-catch from lookup function which is now named, too

Author: line-o

src/main/xar-resources/modules/view.xql

@@ -1,4 +1,5 @@
-xquery version "3.0";
+xquery version "3.1";
+
 
 import module namespace templates="http://exist-db.org/xquery/html-templating";
 import module namespace lib="http://exist-db.org/xquery/html-templating/lib";
@@ -11,19 +12,26 @@ import module namespace review="http://exist-db.org/xquery/documentation/review"
 import module namespace diag="http://exist-db.org/xquery/diagnostics" at "diagnostics.xql";
 import module namespace app="http://exist-db.org/apps/docs/app" at "app.xql";
 
-declare option exist:serialize "method=html5 media-type=text/html";
 
-let $config := map {
+declare namespace output="http://www.w3.org/2010/xslt-xquery-serialization";
+
+declare option output:method "html5";
+declare option output:media-type "text/html";
+
+declare function local:lookup ($functionName as xs:string, $arity as xs:integer) {
+    function-lookup(xs:QName($functionName), $arity)
+};
+
+declare variable $local:templating-configuration := map {
+    $templates:CONFIG_FILTER_ATTRIBUTES : true(),
+    $templates:CONFIG_USE_CLASS_SYNTAX : false(),
     $templates:CONFIG_APP_ROOT : $config:app-root,
     $templates:CONFIG_STOP_ON_ERROR : true()
-}
-let $lookup := function($functionName as xs:string, $arity as xs:integer) {
-    try {
-        function-lookup(xs:QName($functionName), $arity)
-    } catch * {
-        ()
-    }
-}
-let $content := request:get-data()
-return
-    templates:apply($content, $lookup, (), $config)
+};
+
+templates:apply(
+    request:get-data(),
+    local:lookup#2,
+    (),
+    $local:templating-configuration
+)