test(js): lint JS test files

Author: duncdrum

package.json

@@ -3,7 +3,7 @@
   "version": "4.1.3-SNAPSHOT",
   "description": "Documentation package for eXist-db",
   "scripts": {
-    "test": "mocha src/test/mocha/ --recursive --exit",
+    "test": "standard 'src/test/**/*.js' && mocha src/test/mocha/ --recursive --exit",
     "cypress": "cypress run"
   },
   "repository": {
@@ -23,6 +23,11 @@
     "url": "https://github.com/eXist-db/documentation/issues"
   },
   "homepage": "https://github.com/eXist-db/documentation#readme",
+  "standard": {
+    "env": [
+      "mocha"
+    ]
+  },
   "devDependencies": {
     "acorn": "^6.1.1",
     "chai": "^4.2.0",

src/test/cypress/integration/diagnostic_spec.js

@@ -1,3 +1,4 @@
+/* global cy */
 /// <reference types="cypress" />
 
 // This is very slow and therefore skipped. Once diagnostics are re-written
@@ -6,8 +7,7 @@
 
 context.skip('Diagnostics', () => {
   before(() => {
-    cy.visit('/diagnostics.html', {responseTimeout: 60000})
-
+    cy.visit('/diagnostics.html', { responseTimeout: 60000 })
   })
   it('should not find dead links', () => {
     cy.get('h1')

src/test/cypress/integration/documentation_spec.js

@@ -1,3 +1,4 @@
+/* global cy */
 /// <reference types="cypress" />
 
 context('Documentation', () => {
@@ -28,7 +29,6 @@ context('Documentation', () => {
           .parents('section')
           .contains('Integration Testing')
       })
-
     })
 
     it('should have ToC links', () => {

src/test/mocha/test.js

@@ -1,10 +1,10 @@
 const assert = require('assert')
 
 // this is a dummy test js tests are wip
-describe('Array', function() {
-  describe('#indexOf()', function() {
-    it('should return -1 when the value is not present', function() {
-      assert.equal([1,2,3].indexOf(4), -1);
+describe('Array', function () {
+  describe('#indexOf()', function () {
+    it('should return -1 when the value is not present', function () {
+      assert.strictEqual([1, 2, 3].indexOf(4), -1)
     })
   })
 })

src/test/mocha/xqSuite.js

@@ -1,21 +1,19 @@
-const chai = require('chai')
 const supertest = require('supertest')
-const expect = require('chai').expect
 
 // The client listening to the mock rest server
 var client = supertest.agent('http://localhost:8080')
 
-describe('running XQsuite test …', function() {
+describe('running XQsuite test …', function () {
   this.timeout(60000)
   this.slow(45000)
   let runner = '/exist/rest/db/apps/doc/modules/test-runner.xql'
 
-  it('returns 0 errors or failures', function(done) {
+  it('returns 0 errors or failures', function (done) {
     client
       .get(runner)
       .set('Accept', 'application/json')
       .expect('content-type', 'application/json; charset=utf-8')
-      .end(function(err, res) {
+      .end(function (err, res) { // eslint-disable-line handle-callback-err
         try {
           console.group()
           console.group()
@@ -26,14 +24,14 @@ describe('running XQsuite test …', function() {
           done(err)
         } finally {
           console.group()
-          res.body.testsuite.testcase.forEach(function(entry) {
+          res.body.testsuite.testcase.forEach(function (entry) {
             if (entry.failure) {
               console.error([entry.name, entry.failure.message])
               process.exit(1)
             } else if (entry.error) {
               console.error([entry.name, entry.error.message])
               process.exit(1)
-            } else(console.log(entry.name))
+            } else (console.log(entry.name))
           })
           console.groupEnd()
         }