[refactor] Made SonarCloud recommended changes.

Author: chris-evolvedbinary

exist-core/src/main/java/org/exist/xquery/functions/map/SingleKeyMapType.java

@@ -70,8 +70,9 @@ public Sequence get(final AtomicValue key) {
 
     @Override
     public AbstractMapType merge(final Iterable<AbstractMapType> others) {
-        final MapType map = new MapType(getExpression(), context, collator, key, value);
-        return map.merge(others);
+        try (final MapType map = new MapType(getExpression(), context, collator, key, value)) {
+            return map.merge(others);
+        }
     }
 
     @Override

exist-core/src/main/java/org/exist/xquery/value/DoubleValue.java

@@ -109,7 +109,7 @@ public boolean hasFractionalPart() {
         if (isInfinite()) {
             return false;
         }
-        return new DecimalValue(getExpression(), new BigDecimal(value)).hasFractionalPart();
+        return new DecimalValue(getExpression(), BigDecimal.valueOf(value)).hasFractionalPart();
     }
 
     @Override
@@ -192,7 +192,7 @@ public AtomicValue convertTo(final int requiredType) throws XPathException {
                             + "') to "
                             + Type.getTypeName(requiredType));
                 }
-                return new DecimalValue(getExpression(), new BigDecimal(value));
+                return new DecimalValue(getExpression(), BigDecimal.valueOf(value));
             case Type.INTEGER:
             case Type.NON_POSITIVE_INTEGER:
             case Type.NEGATIVE_INTEGER:
@@ -224,7 +224,7 @@ public AtomicValue convertTo(final int requiredType) throws XPathException {
                 if (requiredType != Type.INTEGER && value > Integer.MAX_VALUE) {
                     throw new XPathException(getExpression(), ErrorCodes.FOCA0003, "Value is out of range for type " + Type.getTypeName(requiredType));
                 }
-                return new IntegerValue(getExpression(), Double.valueOf(value).longValue(), requiredType);
+                return new IntegerValue(getExpression(), new Double(value).longValue(), requiredType);
             case Type.BOOLEAN:
                 return new BooleanValue(getExpression(), this.effectiveBooleanValue());
             default:

exist-core/src/main/java/org/exist/xquery/value/FloatValue.java

@@ -167,7 +167,7 @@ public boolean hasFractionalPart() {
         if (isInfinite()) {
             return false;
         }
-        return new DecimalValue(getExpression(), new BigDecimal(value)).hasFractionalPart();
+        return new DecimalValue(getExpression(), BigDecimal.valueOf(value)).hasFractionalPart();
     }
 
     /* (non-Javadoc)