[bugfix] Remove java8-runtime-compatibility. Resolves a peer-review comment from @dizzzz

Author: adamretter

exist-parent/pom.xml

@@ -1152,32 +1152,6 @@
     </distributionManagement>
 
     <profiles>
-        <profile>
-            <id>java8-runtime-compatibility</id>
-            <!--
-                By default, this sets the `-release 8` flag to javac
-                on JDK 9+, so that the produced class files
-                are runtime compatible with Java 8.
-
-                See - https://github.com/eclipse/jetty.project/issues/3244
-
-                You can disable at build time, by using the mvn
-                args: `-P !java8-runtime-compatibility`
-            -->
-            <activation>
-                <jdk>[1.9,)</jdk>
-            </activation>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-compiler-plugin</artifactId>
-                        <configuration>
-                            <release>8</release>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
 
         <profile>
             <!-- NOTE: this is used from the maven-release-plugin -->

extensions/modules/sql/src/test/java/org/exist/xquery/modules/sql/ConnectionIT.java

@@ -142,7 +142,7 @@ public void getConnectionFromModuleIsAutomaticallyClosed() throws EXistException
                 final XQueryContext mainQueryContext = mainCompiledQuery.getContext();
 
                 // get the context of the library module
-                final Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
+                final org.exist.xquery.Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
                 assertEquals(1, libraryModules.length);
                 assertTrue(libraryModules[0] instanceof ExternalModule);
                 final ExternalModule libraryModule = (ExternalModule) libraryModules[0];

extensions/modules/sql/src/test/java/org/exist/xquery/modules/sql/ImplicitConnectionCloseIT.java

@@ -191,7 +191,7 @@ public void getJndiConnectionFromModuleIsAutomaticallyClosed() throws EXistExcep
                 final XQueryContext mainQueryContext = mainCompiledQuery.getContext();
 
                 // get the context of the library module
-                final Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
+                final org.exist.xquery.Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
                 assertEquals(1, libraryModules.length);
                 assertTrue(libraryModules[0] instanceof ExternalModule);
                 final ExternalModule libraryModule = (ExternalModule) libraryModules[0];

extensions/modules/sql/src/test/java/org/exist/xquery/modules/sql/JndiConnectionIT.java

@@ -176,7 +176,7 @@ public void getJndiConnectionFromModuleIsAutomaticallyClosed() throws EXistExcep
                 final XQueryContext mainQueryContext = mainCompiledQuery.getContext();
 
                 // get the context of the library module
-                final Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
+                final org.exist.xquery.Module[] libraryModules = mainQueryContext.getModules("http://mymodule.com");
                 assertEquals(1, libraryModules.length);
                 assertTrue(libraryModules[0] instanceof ExternalModule);
                 final ExternalModule libraryModule = (ExternalModule) libraryModules[0];