Skip to content

Commit 1b09ad6

Browse files
committed
Reworked PR after comments
1 parent 1eecf03 commit 1b09ad6

File tree

2 files changed

+14
-23
lines changed

2 files changed

+14
-23
lines changed

exist-core/src/main/java/org/exist/xquery/functions/fn/FunDocumentURI.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ public FunDocumentURI(final XQueryContext context, final FunctionSignature signa
6060
super(context, signature);
6161
}
6262

63-
/* (non-Javadoc)
64-
* @see org.exist.xquery.Expression#eval(org.exist.xquery.StaticContext, org.exist.dom.persistent.DocumentSet, org.exist.xquery.value.Sequence, org.exist.xquery.value.Item)
65-
*/
63+
@Override
6664
public Sequence eval(final Sequence contextSequence, final Item contextItem) throws XPathException {
6765
if (context.getProfiler().isEnabled()) {
6866
context.getProfiler().start(this);

exist-core/src/test/java/org/exist/xquery/functions/fn/FunDocumentUriTest.java

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,36 +21,29 @@
2121
*/
2222
package org.exist.xquery.functions.fn;
2323

24+
import com.evolvedbinary.j8fu.Either;
2425
import com.googlecode.junittoolbox.ParallelRunner;
25-
import org.exist.test.ExistXmldbEmbeddedServer;
26+
import org.exist.EXistException;
27+
import org.exist.security.PermissionDeniedException;
28+
import org.exist.test.XQueryCompilationTest;
29+
import org.exist.xquery.ErrorCodes;
2630
import org.exist.xquery.XPathException;
27-
import org.junit.ClassRule;
31+
import org.exist.xquery.value.Sequence;
2832
import org.junit.Test;
2933
import org.junit.runner.RunWith;
30-
import org.xmldb.api.base.ResourceSet;
31-
import org.xmldb.api.base.XMLDBException;
3234

33-
import static org.junit.Assert.assertEquals;
35+
import static org.exist.test.XQueryAssertions.assertXQErrorCode;
3436

3537
/**
3638
* @author Dannes Wessels
3739
*/
3840
@RunWith(ParallelRunner.class)
39-
public class FunDocumentUriTest {
40-
41-
@ClassRule
42-
public static final ExistXmldbEmbeddedServer existEmbeddedServer = new ExistXmldbEmbeddedServer(true, true, true);
43-
41+
public class FunDocumentUriTest extends XQueryCompilationTest {
42+
4443
@Test
45-
public void testFnFunDocumentUri() {
46-
47-
try {
48-
final ResourceSet resourceSet = existEmbeddedServer.executeQuery(
49-
"declare context item := 'a'; document-uri()");
50-
51-
} catch (XMLDBException ex) {
52-
XPathException cause = (XPathException) ex.getCause();
53-
assertEquals("XPTY0004", cause.getErrorCode().getErrorQName().getLocalPart());
54-
}
44+
public void testFnFunDocumentUri() throws EXistException, PermissionDeniedException {
45+
final String query = "declare context item := 'a'; document-uri()";
46+
final Either<XPathException, Sequence> result = executeQuery(query);
47+
assertXQErrorCode(ErrorCodes.XPTY0004, result.left().get());
5548
}
5649
}

0 commit comments

Comments
 (0)