Merge pull request #5664 from dizzzz/feature/more_syntaxchanges_1

line-o · web-flow · commit 3b3b863d36c1 · 2025-03-14T09:34:27.000+01:00
diff --git a/exist-core/src/test/java/org/exist/backup/RestoreAppsTest.java b/exist-core/src/test/java/org/exist/backup/RestoreAppsTest.java
@@ -216,7 +216,7 @@ private void restoreAndCheck(BrokerPool pool, Path backup, String expectedMessag
 
             if (expectedMessage != null) {
                 assertEquals(1, listener.skipped.size());
-                assertTrue(listener.skipped.get(0).endsWith(expectedMessage));
+                assertTrue(listener.skipped.getFirst().endsWith(expectedMessage));
             } else {
                 assertEquals(0, listener.skipped.size());
             }
diff --git a/exist-core/src/test/java/org/exist/config/mapping/ConfigurableTest.java b/exist-core/src/test/java/org/exist/config/mapping/ConfigurableTest.java
@@ -62,8 +62,8 @@ public void simple() throws Exception {
         assertEquals(1, object.subclasses.subconfs.size());
         //XXX: assertEquals(2, object.subclasses.subconfs.size());
 
-        assertEquals("1", object.subclasses.subconfs.get(0).getKey());
-        assertEquals("secret1", object.subclasses.subconfs.get(0).getSecret());
+        assertEquals("1", object.subclasses.subconfs.getFirst().getKey());
+        assertEquals("secret1", object.subclasses.subconfs.getFirst().getSecret());
 
         //XXX: assertEquals("2", object.subclasses.subconfs.get(1).getKey());
         //XXX: assertEquals("secret2", object.subclasses.subconfs.get(1).getSecret());
diff --git a/exist-core/src/test/java/org/exist/security/AbstractSecurityManagerRoundtripTest.java b/exist-core/src/test/java/org/exist/security/AbstractSecurityManagerRoundtripTest.java
@@ -256,7 +256,7 @@ public void checkGroupManagerStability() throws XMLDBException, PermissionDenied
             final List<Account> commonGroupManagers = commonGroup.getManagers();
             assertNotNull(commonGroupManagers);
             assertEquals(1, commonGroupManagers.size());
-            assertEquals(commonGroupManagers.get(0).getName(), userName);
+            assertEquals(commonGroupManagers.getFirst().getName(), userName);
 
         } finally {
             //cleanup
diff --git a/exist-core/src/test/java/org/exist/storage/NativeBrokerLockingTest.java b/exist-core/src/test/java/org/exist/storage/NativeBrokerLockingTest.java
@@ -420,7 +420,7 @@ public void accept(final LockTable.LockEventType lockEventType, final long times
             // ignore sync events
             final StackTraceElement[] stackTrace;
             if (entry.getStackTraces() != null && !entry.getStackTraces().isEmpty()) {
-                stackTrace = entry.getStackTraces().get(0);
+                stackTrace = entry.getStackTraces().getFirst();
 
                 final String reason = LockTable.getSimpleStackReason(stackTrace);
                 if (reason != null && (reason.equals("sync") || reason.equals("notifySync"))) {
diff --git a/exist-core/src/test/java/org/exist/storage/journal/JournalTest.java b/exist-core/src/test/java/org/exist/storage/journal/JournalTest.java
@@ -198,7 +198,7 @@ public void getFile() throws IOException {
 
         journalFile = Journal.getFile(mockJournalDir, (short)1);
         assertTrue(Files.exists(journalFile));
-        assertEquals(input.get(0), FileUtils.fileName(journalFile));
+        assertEquals(input.getFirst(), FileUtils.fileName(journalFile));
 
         journalFile = Journal.getFile(mockJournalDir, (short)2);
         assertFalse(Files.exists(journalFile));  // no such file!
@@ -225,7 +225,7 @@ public void getFile() throws IOException {
 
         journalFile = Journal.getFile(mockJournalDir, (short)1);
         assertTrue(Files.exists(journalFile));
-        assertEquals(input.get(0), FileUtils.fileName(journalFile));
+        assertEquals(input.getFirst(), FileUtils.fileName(journalFile));
 
         journalFile = Journal.getFile(mockJournalDir, (short)175);
         assertTrue(Files.exists(journalFile));
diff --git a/exist-core/src/test/java/org/exist/storage/lock/LockManagerTest.java b/exist-core/src/test/java/org/exist/storage/lock/LockManagerTest.java
@@ -826,7 +826,7 @@ public void accept(final LockTable.LockEventType lockEventType, final long times
             // read count first to ensure memory visibility from volatile!
             final int localCount = entry.getCount();
             events.push(new LockAction(lockEventType, groupId, entry.getId(), entry.getLockType(), entry.getLockMode(),
-                    entry.getOwner(), localCount, timestamp, entry.stackTraces == null ? null : entry.stackTraces.get(0)));
+                    entry.getOwner(), localCount, timestamp, entry.stackTraces == null ? null : entry.stackTraces.getFirst()));
         }
 
         public Stack<LockAction> getEvents() {
diff --git a/exist-core/src/test/java/org/exist/storage/structural/NativeStructuralIndexWorkerTest.java b/exist-core/src/test/java/org/exist/storage/structural/NativeStructuralIndexWorkerTest.java
@@ -51,8 +51,8 @@ public void getDocIdRanges_singleContiguous() {
 
         assertEquals(1, ranges.size());
 
-        assertEquals(1, ranges.get(0).start);
-        assertEquals(6, ranges.get(0).end);
+        assertEquals(1, ranges.getFirst().start);
+        assertEquals(6, ranges.getFirst().end);
     }
 
     @Test
@@ -91,8 +91,8 @@ public void getDocIdRanges_singleId() {
 
         assertEquals(1, ranges.size());
 
-        assertEquals(6574, ranges.get(0).start);
-        assertEquals(6574, ranges.get(0).end);
+        assertEquals(6574, ranges.getFirst().start);
+        assertEquals(6574, ranges.getFirst().end);
     }
 
     @Test
diff --git a/exist-core/src/test/java/org/exist/util/serializer/EXISerializerTest.java b/exist-core/src/test/java/org/exist/util/serializer/EXISerializerTest.java
@@ -99,9 +99,9 @@ public void testStartElement() throws Exception {
 		serializer.startElement(testQName, testAttrList);
 		verify(mockEncoder);
 		List<Attributes> capturedAttributeList = capturedAttributes.getValues();
-		assertEquals("local", capturedAttributeList.get(0).getLocalName(0));
-		assertEquals("uri", capturedAttributeList.get(0).getURI(0));
-		assertEquals("value", capturedAttributeList.get(0).getValue(0));
+		assertEquals("local", capturedAttributeList.getFirst().getLocalName(0));
+		assertEquals("uri", capturedAttributeList.getFirst().getURI(0));
+		assertEquals("value", capturedAttributeList.getFirst().getValue(0));
 	}
 	
 	@Test
diff --git a/exist-core/src/test/java/org/exist/xmldb/ResourceTest.java b/exist-core/src/test/java/org/exist/xmldb/ResourceTest.java
@@ -99,7 +99,7 @@ public void readResource() throws XMLDBException, IOException {
         final List<String> resources = testCollection.listResources();
         assertEquals(resources.size(), testCollection.getResourceCount());
 
-        final XMLResource doc = (XMLResource) testCollection.getResource(resources.get(0));
+        final XMLResource doc = (XMLResource) testCollection.getResource(resources.getFirst());
         assertNotNull(doc);
 
         try(final StringWriter sout = new StringWriter()) {
diff --git a/exist-core/src/test/java/org/exist/xquery/RestBinariesTest.java b/exist-core/src/test/java/org/exist/xquery/RestBinariesTest.java
@@ -199,14 +199,14 @@ protected boolean isBooleanType(Result.Value item) throws Exception {
     @Override
     protected byte[] getBytes(final Result.Value item) throws Exception {
         return switch (item.getType()) {
-            case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().get(0).toString());
-            case "xs:hexBinary" -> Hex.decodeHex(item.getContent().get(0).toString());
+            case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().getFirst().toString());
+            case "xs:hexBinary" -> Hex.decodeHex(item.getContent().getFirst().toString());
             default -> throw new UnsupportedOperationException();
         };
     }
 
     @Override
     protected boolean getBoolean(final Result.Value item) throws Exception {
-        return Boolean.parseBoolean(item.getContent().get(0).toString());
+        return Boolean.parseBoolean(item.getContent().getFirst().toString());
     }
 }
diff --git a/extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/AnalyzerConfigTest.java b/extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/AnalyzerConfigTest.java
@@ -115,7 +115,7 @@ public void allParametersIntegerAndSet() throws ParserConfigurationException, IO
 
         assertEquals(2, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("minimumTermLength", extractedConstructorArg1.key());
         assertEquals(Integer.class, extractedConstructorArg1.valueClass());
         assertEquals(Integer.valueOf(2), extractedConstructorArg1.value());
@@ -143,7 +143,7 @@ public void allParametersIntAndSet() throws ParserConfigurationException, IOExce
 
         assertEquals(2, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("minimumTermLength", extractedConstructorArg1.key());
         assertEquals(int.class, extractedConstructorArg1.valueClass());
         assertEquals(2, extractedConstructorArg1.value());
@@ -171,7 +171,7 @@ public void allParametersBooleanAndSet() throws ParserConfigurationException, IO
 
         assertEquals(2, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("minimumTermLength", extractedConstructorArg1.key());
         assertEquals(Boolean.class, extractedConstructorArg1.valueClass());
         assertEquals(Boolean.TRUE, extractedConstructorArg1.value());
@@ -199,7 +199,7 @@ public void allParametersPrimitiveBooleanAndSet() throws ParserConfigurationExce
 
         assertEquals(2, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("minimumTermLength", extractedConstructorArg1.key());
         assertEquals(boolean.class, extractedConstructorArg1.valueClass());
         assertEquals(true, extractedConstructorArg1.value());
@@ -226,7 +226,7 @@ public void allParametersCharArray() throws ParserConfigurationException, IOExce
 
         assertEquals(1, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("punctuationDictionary", extractedConstructorArg1.key());
         assertEquals(char[].class, extractedConstructorArg1.valueClass());
         assertArrayEquals(new char[] {'\'', '-'}, (char[])extractedConstructorArg1.value());
@@ -247,7 +247,7 @@ public void allParametersStringArray() throws ParserConfigurationException, IOEx
 
         assertEquals(1, extractedConstructorArgs.size());
 
-        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.get(0);
+        final AnalyzerConfig.KeyTypedValue<?> extractedConstructorArg1 = extractedConstructorArgs.getFirst();
         assertEquals("punctuationDictionary", extractedConstructorArg1.key());
         assertEquals(String[].class, extractedConstructorArg1.valueClass());
         assertArrayEquals(new String[] {"abc", "def"}, (String[])extractedConstructorArg1.value());
diff --git a/extensions/indexes/range/src/test/java/org/exist/indexing/range/RangeIndexConfigTest.java b/extensions/indexes/range/src/test/java/org/exist/indexing/range/RangeIndexConfigTest.java
@@ -93,10 +93,10 @@ public void errorsHaveSourceContext() throws NoSuchFieldException, IllegalAccess
 
         final RangeIndexConfig config = new RangeIndexConfig(mockConfigNodes, namespaces);
 
-        assertTrue(logCaptor.getLogs().get(0)
+        assertTrue(logCaptor.getLogs().getFirst()
                 .contains("Illegal QName: '" + badCreateQName + "'.. QName is invalid: INVALID_LOCAL_PART"));
 
-        assertTrue(logCaptor.getLogs().get(0)
+        assertTrue(logCaptor.getLogs().getFirst()
                 .contains("(" + mockCollectionXConfUri + ")"));
 
         verify(mockConfigNodes, mockConfigNode, mockCreates, mockCreateDocument, mockCreate, mockEmptyNodeList);
diff --git a/extensions/modules/file/src/test/java/org/exist/xquery/modules/file/RestBinariesTest.java b/extensions/modules/file/src/test/java/org/exist/xquery/modules/file/RestBinariesTest.java
@@ -206,14 +206,14 @@ protected boolean isBooleanType(Result.Value item) throws Exception {
     @Override
     protected byte[] getBytes(final Result.Value item) throws Exception {
         return switch (item.getType()) {
-            case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().get(0).toString());
-            case "xs:hexBinary" -> Hex.decodeHex(item.getContent().get(0).toString());
+            case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().getFirst().toString());
+            case "xs:hexBinary" -> Hex.decodeHex(item.getContent().getFirst().toString());
             default -> throw new UnsupportedOperationException();
         };
     }
 
     @Override
     protected boolean getBoolean(final Result.Value item) throws Exception {
-        return Boolean.parseBoolean(item.getContent().get(0).toString());
+        return Boolean.parseBoolean(item.getContent().getFirst().toString());
     }
 }
diff --git a/extensions/modules/mail/src/test/java/org/exist/xquery/modules/mail/WriteMessageTest.java b/extensions/modules/mail/src/test/java/org/exist/xquery/modules/mail/WriteMessageTest.java
@@ -734,7 +734,7 @@ private static String[] extractMessageBody(final String messageLines[], int mess
             final String line = messageLines[messageBodyOffset++];
             if (".".equals(line) && "".equals(prevLine)) {
                 // drop previous line
-                messageBodyLines.remove(messageBodyLines.size() - 1);
+                messageBodyLines.removeLast();
                 // exit loop, we have read the message body
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ private void restoreAndCheck(BrokerPool pool, Path backup, String expectedMessag`
`216`	`216`
`217`	`217`	`if (expectedMessage != null) {`
`218`	`218`	`assertEquals(1, listener.skipped.size());`
`219`		`- assertTrue(listener.skipped.get(0).endsWith(expectedMessage));`
	`219`	`+ assertTrue(listener.skipped.getFirst().endsWith(expectedMessage));`
`220`	`220`	`} else {`
`221`	`221`	`assertEquals(0, listener.skipped.size());`
`222`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -826,7 +826,7 @@ public void accept(final LockTable.LockEventType lockEventType, final long times`
`826`	`826`	`// read count first to ensure memory visibility from volatile!`
`827`	`827`	`final int localCount = entry.getCount();`
`828`	`828`	`events.push(new LockAction(lockEventType, groupId, entry.getId(), entry.getLockType(), entry.getLockMode(),`
`829`		`- entry.getOwner(), localCount, timestamp, entry.stackTraces == null ? null : entry.stackTraces.get(0)));`
	`829`	`+ entry.getOwner(), localCount, timestamp, entry.stackTraces == null ? null : entry.stackTraces.getFirst()));`
`830`	`830`	`}`
`831`	`831`
`832`	`832`	`public Stack<LockAction> getEvents() {`
Original file line number	Diff line number	Diff line change
`@@ -199,14 +199,14 @@ protected boolean isBooleanType(Result.Value item) throws Exception {`
`199`	`199`	`@Override`
`200`	`200`	`protected byte[] getBytes(final Result.Value item) throws Exception {`
`201`	`201`	`return switch (item.getType()) {`
`202`		`- case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().get(0).toString());`
`203`		`- case "xs:hexBinary" -> Hex.decodeHex(item.getContent().get(0).toString());`
	`202`	`+ case "xs:base64Binary" -> Base64.decodeBase64(item.getContent().getFirst().toString());`
	`203`	`+ case "xs:hexBinary" -> Hex.decodeHex(item.getContent().getFirst().toString());`
`204`	`204`	`default -> throw new UnsupportedOperationException();`
`205`	`205`	`};`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`@Override`
`209`	`209`	`protected boolean getBoolean(final Result.Value item) throws Exception {`
`210`		`- return Boolean.parseBoolean(item.getContent().get(0).toString());`
	`210`	`+ return Boolean.parseBoolean(item.getContent().getFirst().toString());`
`211`	`211`	`}`
`212`	`212`	`}`