Merge pull request #4640 from adamretter/hotfix/rest-internal-server-error

Correct the response code of the REST Server when executing an invalid stored query

Author: line-o

exist-core/src/main/java/org/exist/http/RESTServer.java

@@ -537,9 +537,9 @@ public void doGet(final DBBroker broker, final Txn transaction, final HttpServle
                         LOG.debug(e.getMessage(), e);
                     }
                     if (MimeType.XML_TYPE.getName().equals(mimeType)) {
-                        writeXPathException(response, HttpServletResponse.SC_BAD_REQUEST, encoding, query, path, e);
+                        writeXPathException(response, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, encoding, query, path, e);
                     } else {
-                        writeXPathExceptionHtml(response, HttpServletResponse.SC_BAD_REQUEST, encoding, query,
+                        writeXPathExceptionHtml(response, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, encoding, query,
                                 path, e);
                     }
                 }
@@ -702,10 +702,10 @@ public void doPost(final DBBroker broker, final Txn transaction, final HttpServl
 
                     } catch (final XPathException e) {
                         if (MimeType.XML_TYPE.getName().equals(mimeType)) {
-                            writeXPathException(response, HttpServletResponse.SC_BAD_REQUEST, encoding, null, path, e);
+                            writeXPathException(response, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, encoding, null, path, e);
 
                         } else {
-                            writeXPathExceptionHtml(response, HttpServletResponse.SC_BAD_REQUEST, encoding, null, path, e);
+                            writeXPathExceptionHtml(response, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, encoding, null, path, e);
                         }
                     }
                     return;