Skip to content

Commit 3fbe410

Browse files
committed
[doc] Notes on some further improvements that could be made in future
1 parent 95ae5f1 commit 3fbe410

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

exist-core/src/main/java/org/exist/xquery/XQuery.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,11 +481,23 @@ public Sequence execute(final DBBroker broker, final String expression, final Se
481481
final XQueryContext context = new XQueryContext(broker.getBrokerPool());
482482
final CompiledXQuery compiled = compile(context, expression);
483483
return execute(broker, compiled, contextSequence);
484+
// NOTE(AR) we might consider the below cleanup, but what if a binary value is needed from the result sequence?
485+
// try {
486+
// return execute(broker, compiled, contextSequence);
487+
// } finally {
488+
// context.runCleanupTasks();
489+
// }
484490
}
485491

486492
public Sequence execute(final DBBroker broker, File file, Sequence contextSequence) throws XPathException, IOException, PermissionDeniedException {
487493
final XQueryContext context = new XQueryContext(broker.getBrokerPool());
488494
final CompiledXQuery compiled = compile(context, new FileSource(file.toPath(), true));
489495
return execute(broker, compiled, contextSequence);
496+
// NOTE(AR) we might consider the below cleanup, but what if a binary value is needed from the result sequence?
497+
// try {
498+
// return execute(broker, compiled, contextSequence);
499+
// } finally {
500+
// context.runCleanupTasks();
501+
// }
490502
}
491503
}

0 commit comments

Comments
 (0)