Fix javadoc

Author: dizzzz

exist-core/src/main/java/org/exist/storage/BrokerPool.java

@@ -1917,7 +1917,7 @@ public PluginsManager getPluginsManager() {
 
     /**
      * Represents a change involving {@link BrokerPool#inactiveBrokers}
-     * or {@link BrokerPool#activeBrokers} or {@link DBBroker#referenceCount}
+     * or {@link BrokerPool#activeBrokers} or {@link DBBroker#getReferenceCount}
      *
      * Used for tracing broker leases
      */

exist-core/src/main/java/org/exist/storage/DBBroker.java

@@ -1100,7 +1100,7 @@ public abstract IEmbeddedXMLStreamReader newXMLStreamReader(NodeHandle node, boo
     /**
      * Reads and populates the metadata for a sub-Collection
      *
-     * The entry to read is determined by {@link SubCollectionEntry#uri}
+     * The entry to read is determined by {@link SubCollectionEntry#getUri()}
      *
      * NOTE: It is assumed that the caller holds a {@link LockMode#READ_LOCK} (or better)
      * on the Collection indicated in `entry`.

exist-core/src/main/java/org/exist/storage/io/BlockingInputStream.java

@@ -203,7 +203,7 @@ private int availablePart2() {
      * 
      * 
      * @param b   the <code>byte</code>.
-     * @throws ExistIOException  if an I/O error occurs. In particular, 
+     * @throws IOException  if an I/O error occurs. In particular,
      *             an <code>ExistIOException</code> may be thrown if the 
      *             output stream has been closed.
      */

exist-core/src/main/java/org/exist/util/CharSlice.java

@@ -129,7 +129,7 @@ public int hashCode() {
 
     /**
      * Get the index of a specific character in the sequence. Returns -1 if not found.
-     * This method mimics {@link String#indexOf}
+     * This method mimics {@link String#indexOf(String)}
      * @param c the character to be found
      * @return the position of the first occurrence of that character, or -1 if not found.
      */

exist-core/src/main/java/org/exist/xmldb/RemoteXMLResource.java

@@ -117,8 +117,7 @@ public RemoteXMLResource(final RemoteCollection parent, final XmldbURI docId, fi
      * @param type the type of the remote resource
      *
      * @throws XMLDBException if an error occurs during construction
-     *
-     * @deprecated Use {@link #RemoteXMLResource(Leasable.Lease, RemoteCollection, int, int, XmldbURI, Optional, Optional)}.
+     * @deprecated Use {@link #RemoteXMLResource(RemoteCollection, int, int, XmldbURI, Optional, Optional)}.
      */
     public RemoteXMLResource(final RemoteCollection parent, final XmldbURI docId, final Optional<String> id, final Optional<String> type)
             throws XMLDBException {
@@ -128,7 +127,6 @@ public RemoteXMLResource(final RemoteCollection parent, final XmldbURI docId, fi
     /**
      * Construct a remote XML Resource.
      *
-     * @param xmlRpcClientLease the XML-RPC Client lease
      * @param parent the parent collection
      * @param handle the handle to the remote resource
      * @param pos the position of the remote resource

exist-core/src/main/java/org/exist/xmldb/RemoteXPathQueryService.java

@@ -55,7 +55,6 @@ public class RemoteXPathQueryService extends AbstractRemote implements EXistXPat
      * Creates a new RemoteXPathQueryService instance.
      *
      * @param leasableXmlRpcClient the XML-RPC client lease
-     * @param xmlRpcClient the XML-RPC client
      * @param collection a RemoteCollection value
      */
     public RemoteXPathQueryService(final Leasable<XmlRpcClient> leasableXmlRpcClient, final RemoteCollection collection) {

exist-core/src/main/java/org/exist/xquery/functions/fn/FunSubstring.java

@@ -231,7 +231,7 @@ private boolean validEndPosition(NumericValue end, NumericValue start)
 	 * 
 	 * @see <a href="http://www.w3.org/TR/xpath-functions/#func-substring">w3.org</a>
 	 * 
-	 * @param stringSource	The source string to substring
+	 * @param sourceString	The source string to substring
 	 * @param startingLoc	The Starting Location for the substring, start 
      * index is 1
 	 * 
@@ -253,10 +253,9 @@ private StringValue substring(String sourceString, NumericValue startingLoc)
 	 * 
 	 * @see <a href="http://www.w3.org/TR/xpath-functions/#func-substring">http://www.w3.org/TR/xpath-functions/#func-substring</a>
 	 * 
-	 * @param stringSource	The source string to substring
-	 * @param startingLoc	The Starting Location for the substring, start 
-     * index is 1
-	 * @param length	The length of the substring
+	 * @param sourceString	The source string to substring
+	 * @param startingLoc	The Starting Location for the substring, start index is 1
+	 * @param endingLoc		The Ending Location for the substring
 	 * 
 	 * @return The StringValue of the substring
 	 */